Skip to content

refactor(ios): drop the flat sweep's discarded hittable computation #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Sep 19, 2026
Merged

refactor(ios): drop the flat sweep's discarded hittable computation #2684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+Snapshot.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,12 +446,7 @@ extension RunnerTests {
truncated = true
break
}
guard let node = flatSnapshotNode(
element: element,
index: 0,
parentIndex: 0,
viewport: viewport
) else {
guard let node = flatSnapshotNode(element: element, index: 0, parentIndex: 0) else {
continue
}
let key = "\(node.type)-\(node.label ?? "")-\(node.identifier ?? "")-\(node.value ?? "")-\(node.rect.x)-\(node.rect.y)-\(node.rect.width)-\(node.rect.height)"
Expand Down Expand Up @@ -1323,8 +1318,7 @@ extension RunnerTests {
private func flatSnapshotNode(
element: XCUIElement,
index: Int,
parentIndex: Int?,
viewport: CGRect
parentIndex: Int?
) -> RawAXNode? {
var node: RawAXNode?
let exceptionMessage = RunnerObjCExceptionCatcher.catchException({
Expand All @@ -1338,11 +1332,6 @@ extension RunnerTests {
let valueText = snapshotValueText(element)
let elementType = element.elementType
let enabled = element.isEnabled
let hittable = SnapshotGeometry.isGeometricallyActionable(
enabled: enabled,
frame: frame,
viewport: viewport
)

node = RawAXNode(
index: index,
Expand All @@ -1354,7 +1343,7 @@ extension RunnerTests {
enabled: enabled,
focused: elementHasFocus(element) ? true : nil,
selected: element.isSelected ? true : nil,
hittable: hittable,
hittable: false,
depth: 1,
parentIndex: parentIndex,
hiddenContentAbove: nil,
Expand Down
Loading