Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
enabled auto-merge
November 16, 2026 05:51
blove
added this pull request to the merge queue
Nov 16, 2026
Any commits made after this event will not be merged.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
React
ApprovalCardgetspresentation="dialog", matching the dialog presentation of Angular's approval card.onDismiss; without it Escape does nothing. The dialog never closes itself.inlinestays the default, so existing cards are unchanged.Chat'sapprovalslot the composer placeholder and focus return keep working.Angular's
showEditneeds nothing new: React actions are an app-authored list, so an Edit action is one more entry.Verification
npx nx run-many -t test,type-tests,lint -p reactpasses (8 new tests inapproval-dialog.spec.tsx).npx nx run-many -t build --projects=core,content,reactandnode scripts/react-parity/verify-packages.mjspass.node scripts/react-parity/inventory.mjs --check --drift warnpasses.Chat: the modal opens centred over a scrim with focus on the first action, Escape reachesonDismiss, and after the card unmounts focus returns to the composer. No console errors.🤖 Generated with Claude Code