Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
added this pull request to the merge queue
Nov 16, 2026
Any commits made after this event will not be merged.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the A2UI theme presets in the Angular chat library, fixes a contrast failure in the default A2UI accent, and adds the same four presets to React.
What was wrong (
libs/chat/src/themes)default-light.csshad drifted from the chat's own A2UI tokens: four colours and four shadows differed, so importing the "default" preset changed how surfaces looked.#4f8df5is 3.25:1 as button text, and#4f8df5on the light surface is 3.11:1 as link text.--a2ui-*tokens for agent-rendered surfaces; the chat's--tplane-chat-*colours never change. They also described:hostdefaults and a message field that no longer exist.Changes
Angular
#2f6fedwith white text in light (4.55:1), and#8ab4ffwith#0b1220text in dark (8.96:1). These are the values the React A2UI stylesheet already used. This is a visible change to every default A2UI button, link and choice chip.chat-theme-presets.spec.tsfails when a default preset drifts from the canonical tokens, when a preset leaves a scheme-dependent token (or one a component reads) unset, when presets disagree on their token set, or when button, body, link or error text is below 4.5:1 for the chat defaults or any preset.chat.csscomment, the chat UI guide's gap list and the three example stylesheets are brought in line.React
@threadplane/react/a2ui/themes/{default-light,default-dark,material-light,material-dark}.css, exported and packaged. Each is one rule scoped to.a2ui-surfacethat outranks the base stylesheet, so import order does not matter, and setscolor-schemeso native controls match.Verification
default-lightdiffered from no preset and the dark presets kept light shadows; after it, the default presets compute identically to no preset and every preset holds all its tokens on both pages. React themes apply in either import order, hold under a dark system scheme, and an inline agent primary colour still wins.npx nx run-many -t test,type-tests,lint -p react,chat, and builds ofcore,content,angular,react,chat: pass.verify-packages.mjs,inventory.mjs --check --drift warn, and the 169 verifier spec tests: pass.--a2ui-on-primary, which I confirmed by reading their styles. The example apps were not run.🤖 Generated with Claude Code