Repository navigation
Conversation
This introduces `MaybeRooted<T>`, an enum of the ways that a `Val` or `Ref` may hold a reference to a GC object, and makes the GC-reference variants of `Val` (`ExternRef`, `AnyRef`, `ExnRef`) and of `Ref` (`Extern`, `Any`, `Exn`) hold `Option<MaybeRooted<T>>` instead of `Option<Rooted<T>>`. For now `MaybeRooted<T>` has only one variant, `MaybeRooted::Rooted`, which wraps a `Rooted<T>` as before, so this is a pure refactor with no change in behavior. The point is to give `Val` room for other kinds of GC references, as we will soon do with a followup that adds unrooted references.
cfallin
force-pushed
the
gc-maybe-rooted
branch
from
November 11, 2026 07:17
3a453b5 to
92fac52
Compare
github-actions
Bot
added
fuzzing
Contributor
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:c-api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces
MaybeRooted<T>, an enum of the ways that aValorRefmay hold a reference to a GC object, and makes the GC-reference variants ofVal(ExternRef,AnyRef,ExnRef) and ofRef(Extern,Any,Exn) holdOption<MaybeRooted<T>>instead ofOption<Rooted<T>>.For now
MaybeRooted<T>has only one variant,MaybeRooted::Rooted, which wraps aRooted<T>as before, so this is a pure refactor with no change in behavior. The point is to giveValroom for other kinds of GC references, as we will soon do with a followup that adds unrooted references.