Repository navigation
Make parsing errors downcastable - #2557
Merged
alexcrichton merged 9 commits intoJul 6, 2026
Merged
alexcrichton merged 9 commits into
alexcrichton merged 9 commits into
Conversation
PhoebeSzmucer
commented
Jul 6, 2026
| @@ -347,32 +347,12 @@ impl UnresolvedPackageGroup { | |||
| /// files. | |||
| #[cfg(feature = "std")] | |||
| pub fn parse_dir(path: impl AsRef<Path>) -> anyhow::Result<UnresolvedPackageGroup> { | |||
Contributor
Author
There was a problem hiding this comment.
I kept this function, because it has some external consumers.
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
wasm-tools 1.253.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Limit the element count of fixed-length lists by @eyupcanakman in bytecodealliance/wasm-tools#2537 * wasmparser: Rename BinaryReaderError to Error by @lann in bytecodealliance/wasm-tools#2546 * fix: signature lowering for strings and lists on modules with 64bit memory by @christoph-dfinity in bytecodealliance/wasm-tools#2544 * json-from-wast: name emitted files after the output stem by @eyupcanakman in bytecodealliance/wasm-tools#2542 * Refactor `KebabStr` to not require unsafe code by @alexcrichton in bytecodealliance/wasm-tools#2548 * Add CustomSectionReader -> BinaryReader conversion by @WorldSEnder in bytecodealliance/wasm-tools#2550 * wasmparser: Add Error::missing_wasm_feature by @lann in bytecodealliance/wasm-tools#2549 * fix: use ptr-sized type when returning via ptr indirection under memory64 by @christoph-dfinity in bytecodealliance/wasm-tools#2553 * Synchronize threading intrinsics with specification by @alexcrichton in bytecodealliance/wasm-tools#2554 * Remove `resource.drop async` by @alexcrichton in bytecodealliance/wasm-tools#2552 * Initial work for `versionsuffix` and `external-id` by @alexcrichton in bytecodealliance/wasm-tools#2555 * Make parsing errors downcastable by @PhoebeSzmucer in bytecodealliance/wasm-tools#2557 * Add `SourceMap::resolve_span` for resolving global span locations by @PhoebeSzmucer in bytecodealliance/wasm-tools#2559 * Render error by @PhoebeSzmucer in bytecodealliance/wasm-tools#2560 * Support `external-id` on more items by @alexcrichton in bytecodealliance/wasm-tools#2558 * Release wasm-tools 1.253.0 by @github-actions[bot] in bytecodealliance/wasm-tools#2561 ## New Contributors * @christoph-dfinity made their first contribution in bytecodealliance/wasm-tools#2544 **Full Changelog**: https://github.com/bytecodealliance/wasm-tools/compare/v1.252.0...v1.253.0</pre> <p>View the full release notes at <a href="https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.253.0">https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.253.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!13746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to my earlier PRs i particular #2465 and #2482
Originally when the parsing errors were migrated to be structured errors, I didn't make them downcastable (like I did the resolver errors in #2482). This PR fixes that - the errors are now downcastable, instead of being eagerly rendered into strings.