Repository navigation
Conversation
hozan23
changed the title
hozan23
marked this pull request as ready for review
November 12, 2026 19:55
hozan23
force-pushed
the
feat/enable-intl
branch
from
November 13, 2026 11:46
8685333 to
7d4460c
Compare
hozan23
force-pushed
the
feat/enable-intl
branch
from
November 13, 2026 12:23
7d4460c to
737eaa8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
ENABLE_INTLCMake option (defaultOFF) that builds SpiderMonkey with--with-intl-api, enablingIntl,String.prototype.normalizeand Unicode property escapes (/\p{L}/u). Refs #45._intlbuild type suffix (release_intl,release_weval_intl). Prebuilt artifacts are used when published.intle2e test.release_intlandweval_intljobs, checks for each job's own prebuilt tarball instead of the release tag, and publishes both Intl tarballs.Size:
starling-raw.wasmgrows from ~10.5 MB to ~32 MB, mostly ICU data, only when the option is on.Tested locally:
-DWEVAL=ON -DENABLE_INTL=ONbuilds and passes all 20 e2e tests through weval.