Skip to content

Make Rules an ABC #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefanvanburen wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Make Rules an ABC #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions protovalidate/internal/rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import abc
import dataclasses
import datetime
import typing
Expand Down Expand Up @@ -320,12 +321,13 @@ def sub_context(self) -> "RuleContext":
return RuleContext(fail_fast=self._fail_fast)


class Rules:
class Rules(abc.ABC):
"""The rules associated with a single 'rules' message."""

def validate(self, ctx: RuleContext, message: message.Message): # noqa: ARG002
@abc.abstractmethod
def validate(self, ctx: RuleContext, message: message.Message) -> None:
"""Validate the message against the rules in this rule."""
ctx.add(Violation(rule_id="unimplemented", message="Unimplemented"))
...


@dataclasses.dataclass
Expand Down
Loading