Readme incorrectly shows FSArray background colour rendered over full array #117

Activity

1. moreati commented on Jul 5, 2018

   

   moreati

   on Jul 5, 2018

   Author

   More actions

   Code for copy and paste

   >>> from curtsies import fmtstr
   >>> red_on_blue = fmtstr('hello', 'red', 'on_blue')
   >>> blue_on_red = fmtstr('there', fg='blue', bg='red')
   >>> green = fmtstr('!', 'green')
   >>> full = red_on_blue + ' ' + blue_on_red + green
   >>> full
   on_blue(red('hello'))+' '+on_red(blue('there'))+green('!')
   >>> str(full)
   '\x1b[31m\x1b[44mhello\x1b[49m\x1b[39m \x1b[34m\x1b[41mthere\x1b[49m\x1b[39m\x1b[32m!\x1b[39m'
   >>> print(full)
   hello there!
   

   >>> from curtsies import FSArray
   >>> a = FSArray(3, 14, bg='blue')
   >>> from curtsies import FSArray, fmtstr
   >>> a = FSArray(3, 14, bg='blue')
   >>> a[0:2, 5:11] = fmtstr('hey', 'on_blue') + ' ' + fmtstr('yo', 'on_red'), fmtstr('qwe qw')
   >>> a.dumb_display()
        hey yo
        qwe qw
   
   >>> from curtsies import fsarray
   >>> a = fsarray(['hey', 'there'], bg='cyan')
   >>> a.dumb_display()
   hey
   there
   
2. thomasballinger commented on Jul 7, 2018

   

   thomasballinger

   on Jul 7, 2018

   Member

   More actions

   Whoa that's a big change huh! We could track down the regression, I'd guess it's something to do with the way fsarrays store formatting? Maybe that's something we got rid of?

   Do you have a workaround that work for you now?
3. thomasballinger

   added

   bug

   on Jul 7, 2018
4. moreati commented on Jul 7, 2018

   

   moreati

   on Jul 7, 2018

   Author

   More actions

   I'll have a go at bisecting it.

   Do you have a workaround that work for you now?

   Yes, I'm writing space characters where needed.
5. thomasballinger commented on Jul 7, 2018

   

   thomasballinger

   on Jul 7, 2018

   Last edited by thomasballinger

   Member

   More actions

   This might have been by design, and it's just the readme we should change. Arrays by default being spaces or rendering as all spaces isn't desirable in some cases, e.g. when rendering exactly a terminal-sized rect printing these characters would force a lot more line wraps when resizing the terminal smaller that would otherwise be necessary (I bet this is why it was changed).
6. moreati commented on Jul 9, 2018

   

   moreati

   on Jul 9, 2018

   Author

   More actions

   FTR the change of behavior was introduced by 8cf4240 in Nov 2013
7. thomasballinger commented on Jul 11, 2018

   

   thomasballinger

   on Jul 11, 2018

   Member

   More actions

   Thanks for finding this. I think we should call this works as intended and say the bug is with the docs.
8. thomasballinger

   changed the title [-]FSArray background colour is only rendered[/-] [+]Readme incorrectly shows FSArray background colour rendered over full array[/+] on Jul 11, 2018
9. moreati commented on Jul 11, 2018

   

   moreati

   on Jul 11, 2018

   Author

   More actions

   I'll submit a PR documenting it then