Repository navigation
Link Slack notifications to comment threads - #285
Merged
HamptonMakes merged 2 commits intoOct 28, 2026
Merged
Conversation
mrohan-sq
marked this pull request as ready for review
October 27, 2026 20:26
HamptonMakes
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
CoPlan's Slack comment notifications open the document but leave the triggering discussion closed. Add
?thread=THREAD_IDto links from both Slack senders so clicking a notification opens the right discussion.Use the document's readable address, preserve configured engine mount paths, and keep the discussion target in Slack previews. Keep the discussion target when a renamed or moved document redirects to its new address. This reuses existing discussion-opening behavior without changing recipients or permissions.
Evidence
The shared demo's “request-local memo” discussion opens directly from its link in both themes.
Screenshots were captured locally, but GitHub CLI requires upstream write access to attach them. This account has read access to
block/coplan.How to try it
hampton@example.com./hampton/demo-library, choose the search-latency example, and copy a discussion link.The local demo is running at
http://localhost:3107/hampton/engineering/active-projects/search-latency-cutting-p95-with-a-two-tier-cache?thread=01a17e85-409c-7aac-978f-e7d9bcdd15b3.Testing
spec/system/comment_ux_spec.rband job coverage for single comments, batches, mount paths, and preview links.bundle exec rspecnot run locally; focused coverage passed, with the full suite left to CI:bundle exec rspec spec/jobs/slack_notification_job_spec.rb spec/jobs/slack_notification_delivery_job_spec.rb spec/jobs/slack_unfurl_job_spec.rb spec/requests/slack_events_spec.rb spec/requests/agent_instructions_spec.rb spec/requests/browse_spec.rb— 129 examples passed.bundle exec rspec spec/system/comment_ux_spec.rb:444 spec/system/comment_ux_spec.rb:429 spec/system/comment_ux_spec.rb:468— 3 examples passed.Generated with Codex