Refresh mobile utility surfaces and theme picker

[klopez4212]

Summary

• invert mobile utility surfaces so pages and sheets use the softer page background with raised containers
• rebuild the community theme picker around swipeable Home/Chat previews, accent and appearance controls, and native iOS glass interactions
• align shared sheet/profile spacing and radii, and move Theme into the Community settings card

Related issue

None found.

Testing

• just mobile-check
• just mobile-test (1,871 tests)
• signed iOS Release build installed on a physical iPhone

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c9d63125b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[jedwards27]

:bot: Jude’s code review agent

Reviewed exact head bcb8f511064db20843eeb80e54d8acb86452d277 against base c363ce13c07cb454d6fa92b96d65cb52322c13e9.

Blocking finding

P2 — Commit the theme picker’s Set action as one preference snapshot (mobile/lib/features/settings/theme_picker_page/theme_preview_sheet.dart:84-90)

applySelection() presents Set as one commit, but implements it as up to three independent notifier mutations (setMode, setTheme, setAccent). Every setter calls _save, and _save immediately enqueues a separate cache/outbox operation (mobile/lib/shared/theme/community_theme_provider.dart:112-188). The queue serializes those operations; it does not coalesce them. The sync manager’s pending guard can prevent an obsolete relay publish, but it cannot undo the earlier cache/outbox writes.

Consequently, termination or a failed later write can durably retain/replay a mode-only or mode+theme intermediate state from a single Set action. This behavior is introduced by the new picker commit path; the existing test only checks that nothing is written before Set and that the eventual legacy theme changes, not that Set is atomic.

Author action: add a notifier operation that accepts the complete CommunityThemePreference (or the mode/theme/accent tuple), have Set invoke _save once, and add an instrumented regression proving one cache/outbox snapshot is committed for one Set action.

Validation and remaining verification

• Systems trace found no other author-actionable ownership, identity-scope, relay, platform-channel lifecycle, argument-validation, migration, or release defect.
• Clean exact-head reviewer run: git diff --check passed; just mobile-check passed; just mobile-test passed 1,872/1,872; unsigned release iOS build passed and produced Buzz.app (65.9 MB).
• GitHub’s Mobile, Security, DCO, and normal CI lanes are green. Mark Previous Review Stale is bot/tooling noise, not a product-code failure.
• Native iOS liquid-glass rendering, gestures, and VoiceOver composition remain a confidence gap for iOS device/release validation. In particular, Flutter and the native pagination control both declare adjustable semantics; device validation should confirm this does not create duplicate focus or announcements. No author action on that point unless native observation reproduces it.

[jedwards27]

:bot: Jude’s code review agent

REQUEST CHANGES at exact head bcb8f511064db20843eeb80e54d8acb86452d277 against base c363ce13c07cb454d6fa92b96d65cb52322c13e9.

Blocking finding

[P2] One Set action persists three independently recoverable theme snapshots — mobile/lib/features/settings/theme_picker_page/theme_preview_sheet.dart:84-90, mobile/lib/shared/theme/community_theme_provider.dart:112-190.

applySelection() calls setMode, setTheme, and setAccent sequentially. Each setter calls _save; _save immediately updates provider state, stages relay state, and enqueues its own _persistAndPublish operation. _enqueuePersistence serializes all three operations rather than coalescing them, and each operation writes both the scoped cache and outbox before attempting relay publication.

The sync manager's _pending != preference guard does prevent the first two snapshots from reaching relay publication once the final value has been staged. It does not prevent the first two queued operations from durably overwriting local cache/outbox. A process termination or later write failure can therefore recover or replay a mode-only or mode+theme preference even though the user pressed one atomic-looking Set action. The new widget test proves that drafts do not write before Set and that the eventual value changes, but it does not assert one durable commit.

Author action: add one notifier operation accepting the complete CommunityThemePreference (or equivalent mode/theme/accent tuple), make Set invoke _save once, and add an instrumented persistence regression proving one cache/outbox transition for one Set action.

Verification owner: author for the atomic save and regression; reviewer/CI for replacement-head mobile and native freshness.

Integrated exact-head evidence

• Systems tracing found community/identity scoping, serialized persistence/outbox/retry behavior, per-view iOS channel isolation, bounded native inputs, and no relay schema/auth/migration/release change.
• just mobile-check passed; full mobile suite passed 1,872/1,872; unsigned iOS release build passed and produced Buzz.app at this head.
• Exact-head Mobile, Security, DCO, and normal CI lanes are green. Mark Previous Review Stale is administrative review plumbing, not this product defect.
• The possible duplicate VoiceOver ownership between Flutter Semantics and the native adjustable control was not reproduced on a device. That remains a native-validation confidence gap, not separate author rework. Verification owner: iOS release/device validation.

Any new head invalidates this verdict.

Duplicate orchestration race: an exact-head team verdict had already been submitted seconds earlier. Dismissing this duplicate; review 5044630779 is authoritative.

[wesbillman]

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Reviewed exact head bcb8f511064db20843eeb80e54d8acb86452d277 against base c363ce13c07cb454d6fa92b96d65cb52322c13e9. The intended direction is a consistent utility-surface hierarchy and a single draft-then-commit theme-picker action across Android and iOS. Three exact-head defects still break that contract.

Blocking findings

1. [P2] Commit Set as one durable theme preference — mobile/lib/features/settings/theme_picker_page/theme_preview_sheet.dart:84-90, mobile/lib/shared/theme/community_theme_provider.dart:112-190

   applySelection() makes one user-visible commit but calls setMode, setTheme, and setAccent independently. Each changed field calls _save, immediately mutates/stages state, and enqueues its own cache/outbox persistence. Serialization does not make the group atomic: termination after an early write, or failure of a later write, can leave an intermediate mode-only or mode+theme snapshot durable from one Set action. Add one notifier operation for the complete preference, invoke _save once, and add an instrumented regression proving one cache/outbox transition.

2. [P2] Give untitled Android routes the transformed sheet surface — mobile/lib/shared/widgets/modal_presentation.dart:56-86

   Standard untitled calls with no explicit backgroundColor compute the transformed surfaceColor, but pass null to showModalBottomSheet on non-iOS. The route's BottomSheet therefore resolves its material color from the caller's original theme; the transformed Theme exists only below that material and cannot recolor it. Untitled forum/profile/invite action sheets can consequently paint the old surface while their controls resolve transformed container roles, collapsing the intended contrast. Pass surfaceColor on this path and cover an untitled Android sheet, not only titled Android and iOS cases.

3. [P2] Collapse decorative device previews into their image labels — mobile/lib/features/settings/theme_picker_page/theme_home_preview.dart:31-104

   The overall preview and each mock device are labeled as images, but none excludes descendant semantics. The Home mock includes real text such as the active community name, so assistive technology can traverse/merge decorative internals in addition to “Theme preview,” “Home preview,” and “Chat preview.” Set excludeSemantics: true at the intended image boundary (or wrap the mock screens in ExcludeSemantics) and add a semantics regression asserting the exposed labels and absence of mock content.

Verification

• Source/API-only review; no PR code was checked out or executed.
• Exact-head Mobile, Security, DCO, and standard CI lanes are green. Mark Previous Review Stale is administrative tooling noise and does not address these defects.
• Stored-accent preservation is fixed and causally covered at this head. Native registration, per-view channel cleanup, input bounds, and reduced-motion fallback showed no additional source defect. Physical-device VoiceOver composition remains a release-validation gap.
• The utility transform is marker-idempotent, but a composed utility-page → sheet widget test would strengthen the keystone contract; this is not a separate blocker.

[github-actions]

🔐 Codex Security Review

Status: review required for the current range.

The current range is b49675894b39f87215e4dfc8c1ad4a3c28c6097e...d96ff0bca50887595e64c994c3e133fdaf2bcbd2.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review d96ff0bca50887595e64c994c3e133fdaf2bcbd2 to authorize a new review.
Any previous review applies only to its recorded range.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef9b58e445

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[klopez4212]

🤖 Addressed Wes and Jude’s review blockers on the latest head d96ff0bca:

• Set now submits one complete CommunityThemePreference and persists one cache/outbox snapshot; widget and instrumented-storage regressions cover both boundaries.
• Untitled Android sheets now paint the transformed utility surface at the route level, with modal and emoji-picker regressions.
• Decorative device mocks expose only Home preview / Chat preview image semantics and exclude internal mock content.
• The theme name now remains inside the preview card in height-constrained landscape layouts while retaining the intended portrait spacing.

Validation: just mobile-check, the focused theme/provider/modal/emoji tests, and the full 1,877-test mobile pre-push suite passed. Please re-review the new head.