feat(desktop): restore message quick reactions

[morgmart]

Summary

• restore three learned quick-reaction shortcuts to the desktop message action rail
• keep Add reaction (SmilePlus, h-4 w-4) immediately after shortcuts and left of the restored divider
• preserve Reply, Copy link, More, custom emoji rendering, accessibility labels, and responsive behavior
• hide shortcuts and the divider below sm, while keeping Add reaction available

Tests

At 24c4732c2341b846dccf4ae8fdc2455f700fc44d:

• pnpm exec biome check src/features/messages/ui/MessageActionBar.tsx tests/e2e/message-copy-link.spec.ts tests/e2e/custom-emoji.spec.ts
• pnpm exec tsc --noEmit
• pnpm test — 5,567 passed
• pnpm build:e2e
• pnpm exec playwright test tests/e2e/message-copy-link.spec.ts tests/e2e/custom-emoji.spec.ts --project=smoke — 19 passed
• pnpm exec playwright test tests/e2e/reaction-order.spec.ts --project=smoke — 2 passed
• pre-push: file-size-check, desktop-check, desktop-typecheck, desktop-test

Vogue design review: SHIP.

Screenshot

Restored desktop message action rail: three learned quick reactions, Add reaction (SmilePlus), divider, Reply, Copy link, and More.

[jedwards27]

:bot: Jude’s code review agent — APPROVE

Reviewed: f177f4909d55ad48a36e86a682cd5be4f006f0fe..24c4732c2341b846dccf4ae8fdc2455f700fc44d (exact live head 24c4732c2341b846dccf4ae8fdc2455f700fc44d; clean detached checkouts)

Risk: medium — user-visible message interaction restoring learned reactions, with unchanged reaction publication/removal boundaries.

Behavior/contracts traced: community-scoped learned-reaction selection and post-success recording; custom shortcode filtering, palette URL resolution, and WKWebView relay rewriting; quick-button/picker convergence on the same pending-protected optimistic toggle; unchanged Nostr kind 7 add and kind 5 removal paths; rail ordering/responsiveness; keyboard focus, accessible names, picker focus/Escape, zoom, theme, and narrow layout.

Findings: no blocking or non-blocking code defect found. The rail is three learned shortcuts → Add reaction → divider → Reply → Copy link → More. Stale custom shortcodes are filtered, valid custom emoji retain image rendering, and the shortcuts intentionally remain visually neutral after activation while the message reaction state updates.

Author action: none.

Verification owner: CI/release gate for required exact-head checks. Optional real Tauri/WKWebView touch and VoiceOver observation remains reviewer/native-tooling owned, not author rework.

Validation at matching HEAD:

• just desktop-check — pass (pre-existing informational warnings only)
• just desktop-typecheck — pass
• full just desktop-test — 5,567/5,567 pass
• just desktop-build / pnpm build:e2e — pass (existing chunk warnings only)
• focused shipped Playwright (custom-emoji.spec.ts, message-copy-link.spec.ts) — 19/19 pass
• biome check on all three changed files and git diff --check — pass
• causal mutation changing useQuickReactionEmojis(3, …) to (...0, …) made the focused rail contract fail; restored exact head passed
• browser probes passed for learned custom-emoji image rendering and keyboard activation, focus-within retention, 375×667 responsive ordering/in-viewport layout, dark theme, and simulated 200% root zoom at 900px

Manual/native evidence: screenshot inspection at the exact source revision showed 👍 ❤️ 😂 [Add reaction] | Reply Copy More with correct spacing and no clipping at 900×700. Browser interaction covered hover/keyboard/narrow/zoom/theme/semantic names. Real Tauri-native hover/touch/VoiceOver was not run because the canonical native harness was unavailable and shared-machine GUI launch lacked explicit opt-in.

Residual risk: low, concentrated in unobserved OS-native input/AX delivery. GitHub currently reports only the passing DCO check; broader required CI has not appeared and remains an external merge gate. The changed renderer behavior has focused causal coverage, full Desktop package validation, and browser-visible evidence.

[wpfleger96]

Reviewed exact head 24c4732c2341b846dccf4ae8fdc2455f700fc44d against base f177f4909d55ad48a36e86a682cd5be4f006f0fe.

No blocking or non-blocking source findings. The change restores exactly three learned quick reactions, preserves the shared reaction-selection and post-success learning path, filters stale custom shortcodes, rewrites valid custom-emoji media URLs, hides shortcuts below sm, and places Add reaction before the divider and existing Reply/Copy/More actions.

The focused E2E assertions cover ordered actions, divider placement, neutral shortcut state after selection, custom-emoji behavior, and thread-panel containment. git diff --check passes. CI was still running at review time; required CI remains the merge gate.