fix(desktop): refine sidebar motion - #6690
Open
kursmark-sq wants to merge 2 commits into
Open
Conversation
Co-authored-by: Matt Kursmark <kursmark@squareup.com> Signed-off-by: Matt Kursmark <kursmark@squareup.com> Co-authored-by: Codex <noreply@openai.com>
kursmark-sq
marked this pull request as ready for review
August 24, 2026 17:18
Chessing234
suggested changes
Aug 25, 2026
Chessing234
left a comment
Contributor
There was a problem hiding this comment.
the e2e now expects a single 240ms duration, but two siblings still transition width/left. if --motion-duration-standard isn't 240 this test is the only thing pinning it — please assert the css var or keep the durations you actually animate.
Co-authored-by: Matt Kursmark <kursmark@squareup.com> Signed-off-by: Matt Kursmark <kursmark@squareup.com> Co-authored-by: Codex <noreply@openai.com>
Contributor
Author
|
🤖 Updated by Fizz. The E2E now collects and pauses the complete coordinated transition: gap Addressed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous top-origin scale pulled nav links upward during collapse, creating unnecessary visual noise. The simultaneous translation added more spatial motion while the sidebar chrome was already sliding away. Keeping the fade preserves the anti-ghosting behavior without moving or shrinking the navigation content.
Before / after
Left: before. Right: after.
Normal speed
4× slower
Test plan
The full local repository gate reaches the existing
buzz-terminalPTY fixturedefault_prog_child_observes_the_login_argv0, which times out waiting for$0in this environment. This is unrelated to the desktop CSS/test-only change and is the same local fixture timeout documented on #6314.