Skip to content

fix(pairing-cli): install rustls crypto provider - #2839

Open
bhargavms wants to merge 2 commits into
block:mainfrom
bhargavms:agent/fix-pairing-cli-rustls
Open

fix(pairing-cli): install rustls crypto provider#2839
bhargavms wants to merge 2 commits into
block:mainfrom
bhargavms:agent/fix-pairing-cli-rustls

Conversation

@bhargavms

Copy link
Copy Markdown

Summary

  • install the ring rustls crypto provider before the pairing CLI opens a WSS connection
  • add an explicit rustls dependency so provider selection is stable under workspace feature unification

Root cause

Workspace builds can enable both the ring and aws-lc-rs rustls providers. When both are compiled, rustls cannot choose a process-level provider automatically, so buzz-pair source and buzz-pair target panic before connecting over WSS.

Other Buzz binaries already select a provider explicitly; this applies the same pattern to buzz-pair.

Validation

  • just ci
  • cargo test -p buzz-pairing-cli
  • cargo clippy -p buzz-pairing-cli --all-targets -- -D warnings
  • complete NIP-AB source-to-target identity transfer through a live WSS pairing relay

No practical unit-test seam reproduces Cargo's workspace-wide feature unification inside the pairing CLI package alone, so the runtime regression was validated with the complete WSS transfer.

Signed-off-by: bhargavms <bhargav.m@ewa-services.com>
@bhargavms
bhargavms force-pushed the agent/fix-pairing-cli-rustls branch from 71eb8a2 to 05efbbb Compare July 25, 2026 13:07
@bhargavms
bhargavms marked this pull request as ready for review July 25, 2026 13:15
@bhargavms
bhargavms requested a review from a team as a code owner July 25, 2026 13:15
Co-authored-by: Phuoc (Phu) Do <91568955+dophsquare@users.noreply.github.com>
Signed-off-by: Phuoc (Phu) Do <91568955+dophsquare@users.noreply.github.com>

* origin/main: (111 commits)
  chore(ci): bump desktop smoke E2E timeout to 30 minutes (block#3409)
  release(chart): publish 0.1.7 (block#3393)
  feat(acp): steer claude-code and codex agents via _session/steering (block#3007)
  feat(desktop): apply WebKit rendering workarounds at startup on Linux (block#3271)
  fix(desktop): stabilize flaky DM expansion E2E ordering assertions (block#2004)
  docs(contributing): document the Linux system libraries just ci requires (block#3396)
  fix(desktop): paint community rail full height (block#3382)
  fix(acp): disable goose cron scheduler in managed agent children (block#3144)
  feat(desktop): add custom harness inline from agent dialogs (block#3252)
  chore(compose): remove stale typesense env vars (block#3332)
  feat(desktop): refine agent catalog sharing (block#2439)
  fix(desktop): keep drafts out of the Inbox All view (block#3217)
  docs: restructure DCO guidance into scannable subsection (block#3337)
  Unify mobile loading spinners (block#3314)
  fix(desktop): restore the inbox icon in the sidebar (block#3341)
  fix(desktop): gate codex-acp on a minimum supported version (block#3254)
  feat(cli): add users set-status command for NIP-38 profile status (block#3253)
  fix(composer): scope multiline block formatting (block#3246)
  feat(chart): add relay pod extension points (block#3322)
  Refine mobile attachment picking (block#3313)
  ...
@dophsquare dophsquare added the triage-ready Appropriate for agentic review label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage-ready Appropriate for agentic review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants