fix(desktop): emit singular "mention" feed category to match frontend contract - #2301
Closed
Bartok9 wants to merge 1 commit into
Closed
fix(desktop): emit singular "mention" feed category to match frontend contract#2301Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Bartok9
force-pushed
the
bartok9/feed-category-mention-singular
branch
5 times, most recently
from
July 29, 2026 13:18
ae73396 to
a04aeaf
Compare
Bartok9
force-pushed
the
bartok9/feed-category-mention-singular
branch
7 times, most recently
from
August 5, 2026 13:19
0560e65 to
0ffbb7f
Compare
Bartok9
force-pushed
the
bartok9/feed-category-mention-singular
branch
4 times, most recently
from
August 14, 2026 13:27
2666b74 to
f372981
Compare
Bartok9
force-pushed
the
bartok9/feed-category-mention-singular
branch
5 times, most recently
from
August 24, 2026 13:18
86d9996 to
896448d
Compare
… contract Native `get_feed` emitted feed items with `category: "mentions"` (plural), but the `FeedItemCategory` union (shared/api/types.ts) and every frontend comparison (feed.ts, inbox.ts) use the singular `"mention"` — as does the e2e bridge. The mismatch made native mention items fall through to the needs-action fallback, so a mention toasted as "Needs Action in #channel" instead of "X mentioned you in #channel" (observed live in block#2105), and inbox labeling/priority misclassified them. Emit the singular `"mention"` to match the declared contract. The `types` request-filter keyword ("mentions") is a separate API surface and is left unchanged. Adds a regression test asserting the emitted category. Refs block#2106 Signed-off-by: Bartok9 <danielrpike9@gmail.com> (cherry picked from commit f372981) Signed-off-by: Bartok9 <259807879+Bartok9@users.noreply.github.com> (cherry picked from commit 0828992) Signed-off-by: Bartok9 <259807879+Bartok9@users.noreply.github.com> (cherry picked from commit d78a5b1) Signed-off-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
Bartok9
force-pushed
the
bartok9/feed-category-mention-singular
branch
from
August 24, 2026 14:35
896448d to
5fc04f3
Compare
Contributor
Author
|
Superseded by upstream main: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2106
Native
get_feednow emits feed categorymention(singular) to matchFeedItemCategoryand frontend comparisons so mention toasts/inbox labeling classify correctly. Regression test on emitted category.