Skip to content

Serialize managed agent PATH tests#1777

Merged
wpfleger96 merged 2 commits into
mainfrom
thufir/discovery-path-test-race
Jul 13, 2026
Merged

Serialize managed agent PATH tests#1777
wpfleger96 merged 2 commits into
mainfrom
thufir/discovery-path-test-race

Conversation

@wpfleger96

Copy link
Copy Markdown
Collaborator

Summary

  • Add a shared test-only managed-agent PATH mutex helper.
  • Serialize the discovery cache-refresh test with the existing readiness tests that mutate PATH.
  • Keep the final diff scoped to the managed-agent test race fix.

Validation

  • cargo test --lib managed_agents x3: 692 passed, 0 failed each run.
  • just desktop-tauri-clippy: passed.
  • cargo fmt --manifest-path desktop/src-tauri/Cargo.toml --all -- --check: passed.
  • git diff --check: passed.
  • pnpm check:file-sizes from desktop/: passed.
  • Pre-push hook: desktop-test, mobile-test, rust-tests, desktop-tauri-test all passed.

Quality gate

  • Minimalism: 9/10. The shared helper is load-bearing because it avoids raising the file-size exception while centralizing the exact lock behavior.
  • Elegance: 9/10. The call sites now state intent with lock_path_mutex() rather than repeating poisoned-lock handling.
  • Correctness: 9/10. Both PATH-mutating readiness tests and the PATH/cache discovery test now share the same process-global lock.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
@wpfleger96 wpfleger96 requested a review from a team as a code owner July 13, 2026 00:09
Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
@wpfleger96 wpfleger96 merged commit 1fc7488 into main Jul 13, 2026
45 of 47 checks passed
@wpfleger96 wpfleger96 deleted the thufir/discovery-path-test-race branch July 13, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant