Polish Buzz sidebar theme#1671
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e56ca29174
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… re-apply Pin window-vibrancy to 0.6 so it unifies with the 0.6.0 that Tauri 2.11.2 already links, instead of pulling a second 0.7.1 copy. Both versions define the same Objective-C tagged NSVisualEffectView classes, which risks duplicate-symbol link failures in macOS release bundles. Clear any existing vibrancy view before applying a new material. Since apply_vibrancy appends a tagged view each call while clear_vibrancy removes only one, repeated Buzz enables (theme switches, follow-system flips) would otherwise stack views and leave a stale blur behind when switching back to a non-Buzz theme. Signed-off-by: npub13fn4ahfnvaa2qwylvegdgeajqs0mph6v4qsw4jcqnw4mjh3hzh2quuucm5 <8a675edd33677aa0389f6650d467b2041fb0df4ca820eacb009babb95e3715d4@sprout-oss.stage.blox.sqprod.co>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bafcf40ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The Buzz translucent treatment (transparent root/body + semi-transparent sidebar gradient) relies on the native macOS NSVisualEffectView vibrancy layer painting behind the webview. On Windows/Linux set_window_vibrancy is a no-op, but the window is transparent globally, so a transparent root showed raw desktop content through the UI. Gate the data-buzz-translucent marker and transparent root background to macOS; other platforms fall back to the opaque Buzz gradient with the normal bg-background body fill. Signed-off-by: npub13fn4ahfnvaa2qwylvegdgeajqs0mph6v4qsw4jcqnw4mjh3hzh2quuucm5 <8a675edd33677aa0389f6650d467b2041fb0df4ca820eacb009babb95e3715d4@sprout-oss.stage.blox.sqprod.co>
2b0fe79 to
075c1fc
Compare
Summary
Snapshots
Testing
pnpm checkpnpm typecheckcargo check --manifest-path desktop/src-tauri/Cargo.tomlrust-tests,desktop-test,mobile-test,desktop-tauri-testpnpm exec playwright test tests/e2e/buzz-theme-screenshots.spec.ts --project=smoke -g "buzz (light|dark) sidebar gradient"