moderation(L6): verify moderation reads against full request URL incl. query#1607
Merged
Merged
Conversation
…. query Wren's L7 sweep (#1591) found a NIP-98 auth mismatch that 401'd `buzz moderation reports` and `audit` in normal use: the CLI signs the full request URL — query string included (`?limit=…&status=…`) — but the relay reconstructed the expected URL from the bare path only, and buzz-auth URL normalization preserves query strings, so they never matched. `restricted` was unaffected (no query). Fix: `authorize_moderation_read` now takes the request's raw query (axum `RawQuery`) and appends it verbatim to the path before building the NIP-98 expected URL, so the relay verifies against the actual request URI the client signed. Verbatim (not re-parsed) keeps the match byte-exact regardless of param order/encoding. `restricted` passes `None` and keeps its bare-path expectation. This is the direction Wren recommended: verifying the full request URL keeps future filtered reads honest. Regression coverage (4 tests, bridge.rs): a query-bearing GET verifies iff the expected URL carries the same query (`reports?limit=20&status=open`, `audit?limit=20`); an anti-regression control proves the same event is rejected with a URL mismatch against the bare path (the pre-fix behavior); and `restricted` still verifies query-less. A test-local helper mirrors the production query-reconstruction so the seam is pinned without a DB harness. Validation on base 8059413 (toolchain 1.95.0, PATH=repo bin): fmt --check, clippy -p buzz-relay --all-targets -D warnings, test -p buzz-relay --lib all green (503 passed / 0 failed / 2 ignored — 499 prior + 4 new). git diff --check clean. Delta is bridge.rs only, +157/-5. Co-authored-by: Tyler Longwell <tlongwell@block.xyz> Signed-off-by: Tyler Longwell <tlongwell@block.xyz>
tlongwell-block
merged commit Jul 7, 2026
9da503f
into
eva/community-moderation
22 of 28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the NIP-98 read-auth mismatch Wren found in the #1591 L7 sweep: CLI signs the full request URL (query included), relay verified against the bare path only →
buzz moderation reports/audit401'd in normal use.Fix:
authorize_moderation_readtakes the request's raw query (axumRawQuery) and appends it verbatim to the path before building the NIP-98 expected URL.restrictedpassesNone, keeps bare-path expectation.Tests (4, bridge.rs): query-bearing GET verifies iff expected URL carries the same query (
reports?limit=20&status=open,audit?limit=20); anti-regression control proves the same event is rejected against the bare path;restrictedstill verifies query-less.Validation on base
80594133: fmt --check, clippy -p buzz-relay --all-targets -D warnings, buzz-relay --lib 503/503 green. Delta is bridge.rs only, +157/-5.Co-authored-by: Tyler Longwell tlongwell@block.xyz
Signed-off-by: Tyler Longwell tlongwell@block.xyz