Skip to content

bl apps: name the apps in other workspaces that hold the app limit - #46

Closed
nathan-thillairajah wants to merge 2 commits into
eggy/apps-limit-guidancefrom
irving/bot-2573-cli-slot-holders
Closed

nathan-thillairajah wants to merge 2 commits into
eggy/apps-limit-guidancefrom
irving/bot-2573-cli-slot-holders

Conversation

@nathan-thillairajah

Copy link
Copy Markdown
Contributor

Background

An owner at the app limit couldn't tell which apps were using it, because the limit counts every workspace while bl apps list --scope owned shows only the current one (BOT-2573). squareup/blockplat-compose#567 makes the control plane's 409 list the slot holders, only for the owner. This is the bl side. It's stacked on #45.

What changes

When the 409 includes slot_holders, bl adds a line naming the apps in other workspaces, with their workspace, and points at bl workspace switch. It names at most ten. When the limit is for one site type and some holders have no recorded type, it also says those count against both limits. With an older server, or for a caller who isn't the owner, the output is the same as #45.

Testing

just check passes. By hand, a locally built bl apps create against a local control plane running #567, with the owner at the limit and one app in another workspace, printed:

POST /v1/agent/apps/book-club/reserve failed with 409 Conflict (owner_site_limit_reached)
You already have as many apps as your plan allows, so nothing was changed. Existing apps keep working. The allowance counts the apps you own in every workspace, not just this one; `bl apps list --scope owned` shows the ones in this workspace and your current usage.
1 app that counts against your limit is in another workspace, so it isn't listed here: team-1 (workspace ws2). Run `bl workspace switch` to manage it.
next_action: Review your owned sites and delete one you no longer need, then retry.

Risk

Message text only. It's safe to merge before #567 deploys, because without the field nothing changes.

🤖 Generated with Claude Code

nathan-thillairajah and others added 2 commits November 3, 2026 17:06
When the control plane's limit error lists slot holders (it does only
for the owner), print the ones outside this workspace, since `bl apps
list` here doesn't show them, and say when apps without a site type
count against both limits.

Co-authored-by: Irving B <6c4c50b3b6dee89feaca78ea87eb5c8fde651d2d7b39d6da8c9354ce7a34e313@remote-agent-pilot.communities.buzz.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name at most ten apps from other workspaces, show the summary only on a
409, and say the apps count against the limit rather than "using it".

Co-authored-by: Irving B <6c4c50b3b6dee89feaca78ea87eb5c8fde651d2d7b39d6da8c9354ce7a34e313@remote-agent-pilot.communities.buzz.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nathan-thillairajah
nathan-thillairajah requested a review from a team as a code owner November 3, 2026 22:10
@nathan-thillairajah
nathan-thillairajah marked this pull request as draft November 3, 2026 23:07

@kalvinnchau kalvinnchau left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 No actionable findings in the delta against #45. Full workspace tests and 22 CLI process probes passed. The parent review’s documentation finding remains separate; live server integration was not exercised.

@nathan-thillairajah

Copy link
Copy Markdown
Contributor Author

🤖 Closing as superseded by BOT-2583 (move an owner's apps with them when they change workspace), together with squareup/blockplat-compose#567. A user can't act on apps left in a previous workspace, so they don't need them named. #45 keeps the rest of the limit guidance. Leaving the branch in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants