Repository navigation
bl apps: name the apps in other workspaces that hold the app limit - #46
Closed
nathan-thillairajah wants to merge 2 commits into
Closed
nathan-thillairajah wants to merge 2 commits into
nathan-thillairajah wants to merge 2 commits into
Conversation
When the control plane's limit error lists slot holders (it does only for the owner), print the ones outside this workspace, since `bl apps list` here doesn't show them, and say when apps without a site type count against both limits. Co-authored-by: Irving B <6c4c50b3b6dee89feaca78ea87eb5c8fde651d2d7b39d6da8c9354ce7a34e313@remote-agent-pilot.communities.buzz.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name at most ten apps from other workspaces, show the summary only on a 409, and say the apps count against the limit rather than "using it". Co-authored-by: Irving B <6c4c50b3b6dee89feaca78ea87eb5c8fde651d2d7b39d6da8c9354ce7a34e313@remote-agent-pilot.communities.buzz.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nathan-thillairajah
marked this pull request as draft
November 3, 2026 23:07
kalvinnchau
approved these changes
Nov 3, 2026
kalvinnchau
left a comment
There was a problem hiding this comment.
🤖 No actionable findings in the delta against #45. Full workspace tests and 22 CLI process probes passed. The parent review’s documentation finding remains separate; live server integration was not exercised.
Contributor
Author
|
🤖 Closing as superseded by BOT-2583 (move an owner's apps with them when they change workspace), together with squareup/blockplat-compose#567. A user can't act on apps left in a previous workspace, so they don't need them named. #45 keeps the rest of the limit guidance. Leaving the branch in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
An owner at the app limit couldn't tell which apps were using it, because the limit counts every workspace while
bl apps list --scope ownedshows only the current one (BOT-2573). squareup/blockplat-compose#567 makes the control plane's 409 list the slot holders, only for the owner. This is theblside. It's stacked on #45.What changes
When the 409 includes
slot_holders,bladds a line naming the apps in other workspaces, with their workspace, and points atbl workspace switch. It names at most ten. When the limit is for one site type and some holders have no recorded type, it also says those count against both limits. With an older server, or for a caller who isn't the owner, the output is the same as #45.Testing
just checkpasses. By hand, a locally builtbl apps createagainst a local control plane running #567, with the owner at the limit and one app in another workspace, printed:Risk
Message text only. It's safe to merge before #567 deploys, because without the field nothing changes.
🤖 Generated with Claude Code