Repository navigation
fix(web): reuse host identity and verify service editor shortcuts - #3
Open
jdd-canada wants to merge 1 commit into
Open
jdd-canada wants to merge 1 commit into
jdd-canada wants to merge 1 commit into
Conversation
Use the existing getHostEnvironmentId bridge and remove the duplicate desktop IPC and contract. Exercise the selected workspace editor shortcut with the details panel open and closed. Verification: check:changed against the PR base passed 129 tests and six compiler checks. Disabling both shortcut handlers makes the strengthened browser test fail.
github-actions
Bot
added
vouch:unvouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parent PR adds
getHomeEnvironmentId, but its base already exposes the same read throughgetHostEnvironmentId. Reuse that existing bridge and remove the duplicate handler, channel, preload entry, contract and test. Keep the same-home routing, missing-ID retry and picker fixes. The combined upstream diff becomes web-only.The ChatView regression now presses Ctrl+O with the details panel open and closed and checks the editor, selected workspace path and destination environment. A temporary probe disabling both shortcut handlers fails this assertion; the original marker-only assertion stayed green under that probe.
Verification:
vp run check:changed e455200077ce60806a01c8f28435b58860dcfc74 --concurrency 2passes format, lint, both knip checks, typecheck, 129 tests in 12 files and six React Compiler checks.0.1.7+local.31358.audit2, with build metadata identifying 3390fd5. On Linux under Xvfb, paired the desktop to an independent server built from this source, sharing one isolated T3 home with Local environment disabled.codelauncher recorded the arguments and invoked Void's real Code OSS 1.100.3 in an isolated profile. The editor displayed the selected file and its expected contents.Fork CI: the agent-context budget job compares against the fork's older
main(8b44f42), rather than this PR's target branch.apps/server/src/provider/agentContextBudget.jsonis unchanged between target 828d70c and cleanup 3390fd5; the reported increases are inherited from the target branch. Other CI jobs remain queued for Blacksmith runners. The checks and packaged verification above were run locally.This is a follow-up to pingdotgg#31358 against its existing author branch. The original before/after captures remain in that PR; the images below show the current packaged verification. Native Windows/WSL and a systemd-installed service were not exercised.
Implementation: GPT-6.1 Sol in T3 Code through the Codex harness.