Skip to content

fix(miniapp): 修复发布构建中的测试跳过冲突 - #4111

Merged
binarywang merged 1 commit into
developfrom
fix/miniapp-surefire-skip
Aug 22, 2026
Merged

fix(miniapp): 修复发布构建中的测试跳过冲突#4111
binarywang merged 1 commit into
developfrom
fix/miniapp-surefire-skip

Conversation

@binarywang

@binarywang binarywang commented Aug 22, 2026

Copy link
Copy Markdown
Owner

问题

发布工作流使用 -Dmaven.test.skip=true 跳过测试编译,但 miniapp 模块固定 Surefire 的 <skip>false</skip>,导致 TestNG 执行 suite 时找不到未编译的 WxMaSubscribeServiceImplUrlTest

修复

让 Surefire 的 skip 读取 ${maven.test.skip},使发布流程一致跳过测试编译与执行;常规构建仍运行该 TestNG suite。

验证

  • mvn -pl weixin-java-miniapp clean test -Dmaven.test.skip=true -Dgpg.skip=true --no-transfer-progress
  • mvn -pl weixin-java-miniapp clean test -Dgpg.skip=true --no-transfer-progress(3 tests, 0 failures)

@binarywang
binarywang marked this pull request as ready for review August 22, 2026 13:54
Copilot AI lite review requested due to automatic review settings August 22, 2026 13:55
@binarywang
binarywang merged commit 655c5f6 into develop Aug 22, 2026
1 of 2 checks passed
@augmentcode

augmentcode Bot commented Aug 22, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

总结:将 miniapp 模块 Surefire 的 skip 配置改为读取 ${maven.test.skip},不再强制执行测试。
影响:发布构建传入 -Dmaven.test.skip=true 时会同时跳过测试编译与 TestNG suite;未传入时仍按原有 suite 执行测试。

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

配置已与 Maven 测试跳过参数一致,且没有未解决的审查意见。

Pull request overview

修复 miniapp 发布构建中测试跳过配置不一致的问题。

Changes:

  • 将 Surefire 的 skip 绑定到 ${maven.test.skip}
  • 保持常规构建执行 TestNG 测试套件。
File summaries
File Description
weixin-java-miniapp/pom.xml 调整 Surefire 测试跳过配置。
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@binarywang
binarywang deleted the fix/miniapp-surefire-skip branch August 22, 2026 13:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6602690e54

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread weixin-java-miniapp/pom.xml
@binarywang binarywang changed the title fix(miniapp): 修复发布构建中的测试跳过冲突 fix(channel): 修复发布构建中的测试跳过冲突 Aug 22, 2026
@binarywang binarywang changed the title fix(channel): 修复发布构建中的测试跳过冲突 fix(miniapp): 修复发布构建中的测试跳过冲突 Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants