use for-each instead of enumerations - #2043
Closed
winfriedgerlach wants to merge 2024 commits into
Closed
winfriedgerlach wants to merge 2024 commits into
winfriedgerlach wants to merge 2024 commits into
Conversation
…ing - relates to github bcgit#1950
minor refactor - removed use of toUpperCase() in BCMLDSAPrivateKey
…bc-java into bukka-mail-smime-auth-enveloped
…t for encryption check on SMIMEAuthEnvelopedData messages to SMIMEToolkit.
… into moonfruit-gm-signature-spi
…-java into Marcono1234-OpenBSDBCrypt-doc
# Conflicts: # core/src/main/java/org/bouncycastle/crypto/generators/ECCSIKeyPairGenerator.java # core/src/main/java/org/bouncycastle/crypto/kems/SAKKEKEMSGenerator.java # core/src/main/java/org/bouncycastle/crypto/params/ECCSIKeyGenerationParameters.java # core/src/main/java/org/bouncycastle/crypto/signers/ECCSISigner.java
Mayo See merge request root/bc-java!75
RFC 6507 and 6508 See merge request root/bc-java!73
- draft-connolly-tls-mlkem-key-agreement-05
additional PQC tests added support for AES_WRAP_PAD to CMS.
Contributor
|
Thanks for the PR. We're still shipping Java 4, slowly migrating to more modern styles as overlays kick in. Closing as partially merged and on-going. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
David put in the effort and made
ASN1Sequenceiterable. But many places in the code still use the oldEnumerationaccess pattern. Would you accept changing these tofor-eachwhere possible? (better readability, elements are parameterized as<ASN1Encodable>which improves type safety)