Repository navigation
Conversation
Cover uv.lock shapes exercised by the rules_py uv e2e cases that were not yet tested here: a single version split into per-platform records, conflicting dependency groups pinning different versions, hashless wheels, platform-specific wheels without an sdist, local and epoch versions, a root extra enabled through a dev group, bare linux_<arch> wheel tags, and abi3 wheel preference on newer interpreters.
Selecting dependency groups, including self references to a project's own extras, is handled by pip.configure, so the parse_requirements tests only check what the uv.lock graph makes reachable.
Collaborator
Author
|
This PR was prepared by Claude Code (an AI agent) on behalf of the author. The author reviewed the change before it was opened. Review comments will be handled by the author, who may use an agent to draft changes and replies that they review before posting. This comment was generated by an AI agent and approved by the author. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
uv.locksupport inparse_requirementsis new, so this checks that it isrobust against the lock file shapes that real projects produce. The uv
end-to-end cases in rules_py each guard a regression that was found with a real
lock file, and the ones that apply to parsing the lock file are ported here as
unit tests:
tool.uv.environments,hash,+) and epoch (!) versions,linux_<arch>wheel platform tags,abi3wheel preference on newer interpreters.All of them pass without changes to the implementation. Selecting the
dependency groups is left to
pip.configure, so these tests only check what theuv.lockdependency graph makes reachable.