fix(typescript): exclude typescript lib declarations in...#875
Merged
alexeagle merged 2 commits intoJun 19, 2019
Merged
Conversation
gregmagolan
changed the title
...node_module_library transitive_declarations as the including /node_modules/typescript/lib/lib.*.d.ts is controlled by compilerOptions libs. Including all of the can cause typings conflicts. Test coverage also added for this that verifies that typescript/lib/typescript.d.ts and typescript/lib/tsserverlibrary.d.ts are available since we must exclude other typescript/lib/ .d.ts files which are controlled by the compilerOptions.libs config. Also verify that libs not specified such as lib.webworkder.d.ts in compileOptions.libs config are not included in the compilation unit. See #875 for more details.
...in generated ts_library tsconfig. This fixes an issue where the @bazel/tsetse plugin values in a user's config would always be overridden by ts_library and not honoured. Also remove disable_tsetse_for_external test as we no longer doing this.
Collaborator
Author
|
Fix for included and test coverage as well |
Closed
14 tasks
alexeagle
approved these changes
Jun 19, 2019
Collaborator
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
okay, I convinced myself that the disable_tsetse stuff is no longer needed.
alexeagle
pushed a commit
that referenced
this pull request
Jun 19, 2019
...node_module_library transitive_declarations as the including /node_modules/typescript/lib/lib.*.d.ts is controlled by compilerOptions libs. Including all of the can cause typings conflicts. Test coverage also added for this that verifies that typescript/lib/typescript.d.ts and typescript/lib/tsserverlibrary.d.ts are available since we must exclude other typescript/lib/ .d.ts files which are controlled by the compilerOptions.libs config. Also verify that libs not specified such as lib.webworkder.d.ts in compileOptions.libs config are not included in the compilation unit. See #875 for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...node_module_library transitive_declarations as the including of these .d.ts is controlled by compilerOptions libs (except for typescript.d.ts and tsserverlibrary.d.ts which are imported standardly)
. Including all of the can cause typings conflicts.
Unblocks angular/angular#31019