fix(esbuild): update to esbuild 0.11#2559
Merged
Merged
Conversation
jbedard
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
alexeagle
approved these changes
Mar 26, 2021
Collaborator
|
I think there needs to be another change in there to account for "The extensions .mjs and .cjs are no longer implicit" which is the cause of the current failure? Maybe I'm making that up 🤔 |
Collaborator
Author
|
The current failure is only on windows though? How is that possible? |
jbedard
force-pushed
the
esbuild-10
branch
7 times, most recently
from
1ca1c7b to
efa3eec
Compare
jbedard
changed the title
jbedard
force-pushed
the
esbuild-10
branch
6 times, most recently
from
33f9496 to
ae13327
Compare
jbedard
changed the title
mattem
approved these changes
Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2552
The golden change is interesting but I think makes sense... I think all those modules should be treated the same? I'm not sure why it outputs UMD, but now it's consistent.