-
Notifications
You must be signed in to change notification settings - Fork 269
fix: split comma-separated tags in search_notes tags parameter #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jagadeeswara-ks
wants to merge
5
commits into
basicmachines-co:main
from
jagadeeswara-ks:fix/search-notes-tags-comma-split
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1fc96c0
fix: split comma-separated tags in search_notes tags parameter
jagadeeswara-ks 74e0522
Merge branch 'main' into fix/search-notes-tags-comma-split
jagadeeswara-ks a2c81cd
Merge branch 'main' into fix/search-notes-tags-comma-split
phernandez af64ada
Merge branch 'main' into fix/search-notes-tags-comma-split
phernandez 4560638
Merge branch 'main' into fix/search-notes-tags-comma-split
phernandez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
tagsreceives an invalid JSON value such as an object or number,parse_tagsfalls through toparse_tags(str(tags)), so the MCP argument validator now accepts malformed filters as a literal tag instead of failing validation. The previouscoerce_listpath left non-string/non-list values for Pydantic to reject, so bad client payloads surfaced immediately; now they become successful searches with confusing no-result behavior. Use a search-specific parser that only acceptsstr,list[str], orNonebefore splitting comma strings.Useful? React with 👍 / 👎.