Repository navigation
fix(deps): pin FastAPI to 0.139.0 - #1823
Merged
Merged
Conversation
The read cache imports fastapi.dependencies.utils.get_flat_dependant, which FastAPI removed in 0.140.7. The >=0.136.1 floor let fresh installs resolve 0.140.13+, so bm status failed with "cannot import name 'get_flat_dependant'". Pin the exact version CI tests. Adds the v0.24.1 changelog entry and applies a ruff format rewrap left on main by #1790. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018CoZ3jWnMJsyQsik4tPySk Signed-off-by: phernandez <paul@basicmachines.co>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh installs of v0.24.0 fail on
bm status:src/basic_memory/read_cache/routes.pyimports FastAPI's privateget_flat_dependant, which FastAPI removed in 0.140.7. Our lock pins 0.139.0, so CI never saw it, but thefastapi[standard]>=0.136.1floor let new installs resolve 0.140.13 or later. Reported on Discord by lastguru. Reproduced withuvx --from basic-memory==0.24.0 --with fastapi==0.140.13 bm status.Change
fastapi[standard]==0.139.0: an exact pin to the version CI already tests. No code change.uv.lock: only the specifier changes.chatgpt_importer.py:ruff formatrewrap left unformatted on main by fix(cli): import ChatGPT conversations that have no title #1790.Verified
A fresh isolated install of this branch's wheel resolves fastapi 0.139.0 and imports
basic_memory.read_cache.routesandbasic_memory.api.app.Follow-up
The code still uses private FastAPI helpers (
get_flat_dependanthere;get_dependantandsolve_dependenciesinmcp/async_client.py). Moving off them should come with a deliberate FastAPI upgrade.🤖 Generated with Claude Code
https://claude.ai/code/session_018CoZ3jWnMJsyQsik4tPySk