You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As suggested in issue #31 I think we should move away from a popup and instead expand out the warnings that appear to show more information on the warning.
I agree. A whole new page would be a good idea but only if you can quickly go back to your lint results. The way it works atm should be easy to extend a bit.
How about we have a suggestions folder, we then have each suggestion in a Markdown file. One file per suggestion. These can then be edited and maintained. We can then pull that markdown either into the CLI or into the GH Pages by using a markdown to HTML converter.
We can then use these suggestions with the popup for now, but easy to change and use in another way. Maybe an collapsible suggestions off the warnings? http://getbootstrap.com/javascript/#collapse
@piperhaywood Welcome to open source! And great, go for it. If you wanna discuss anything lengthy or overly technical feel free to do so here, its good to have a paper trail - for more quick questions which maybe don't need to be on github https://gitter.im/basicallydan/forkability is better :) me and @M-Zuber often hang out there.
Also, thanks for showing an interest in contributing!
@basicallydan@M-Zuber Thanks very much! Got a little ways with it yesterday, I'm hoping to take a further look at it shortly and submit a PR later this week :)
Great! Thank you for the update.
If you want any feedback on the code, even if you think it is not ready to merge, just open a PR with [WIP] in the title
Thanks for checking in! I've been visiting my folks in the states for
the holidays and have been pretty lax with projects and such. Will try
to take a look when I'm back!
Activity
basicallydan commentedon Dec 3, 2014
I agree. A whole new page would be a good idea but only if you can quickly go back to your lint results. The way it works atm should be easy to extend a bit.
If not the popup will probably get too big!
hpoom commentedon Dec 3, 2014
How about we have a suggestions folder, we then have each suggestion in a Markdown file. One file per suggestion. These can then be edited and maintained. We can then pull that markdown either into the CLI or into the GH Pages by using a markdown to HTML converter.
We can then use these suggestions with the popup for now, but easy to change and use in another way. Maybe an collapsible suggestions off the warnings? http://getbootstrap.com/javascript/#collapse
basicallydan commentedon Dec 3, 2014
Yes, that would work fine - although I'm not sure whether it'd look good on the CLI, so to start with just getting it in
gh-pageswould do!As for using the Bootstrap collapsible, this also sounds like a good plan :)
piperhaywood commentedon Dec 5, 2015
I might just try to take a quick look at this as part of a 24 Pull Requests event! First time looking at an issue on an open source project... :)
basicallydan commentedon Dec 5, 2015
@piperhaywood Welcome to open source! And great, go for it. If you wanna discuss anything lengthy or overly technical feel free to do so here, its good to have a paper trail - for more quick questions which maybe don't need to be on github https://gitter.im/basicallydan/forkability is better :) me and @M-Zuber often hang out there.
Also, thanks for showing an interest in contributing!
M-Zuber commentedon Dec 6, 2015
I second @basicallydan.
Welcome to the wonderful world of open source.
Happy to help out with anything you need.
p.s. feel free to ping me if you are interested in help on other projects as well
piperhaywood commentedon Dec 6, 2015
@basicallydan @M-Zuber Thanks very much! Got a little ways with it yesterday, I'm hoping to take a further look at it shortly and submit a PR later this week :)
M-Zuber commentedon Dec 6, 2015
Great! Thank you for the update.
If you want any feedback on the code, even if you think it is not ready to merge, just open a PR with [WIP] in the title
basicallydan commentedon Dec 8, 2015
👍 to @M-Zuber's comment.
M-Zuber commentedon Dec 27, 2015
Hello @piperhaywood,
Just checking in. I am aware that there is such a thing as life, so please do not feel pressured.
piperhaywood commentedon Jan 6, 2016
Thanks for checking in! I've been visiting my folks in the states for
the holidays and have been pretty lax with projects and such. Will try
to take a look when I'm back!
On 27/12/2015 09:17, Mordechai Zuber wrote:
basicallydan commentedon Jan 6, 2016
@piperhaywood No problem, I've been in almost exactly the same position. Hope you had a good break 👍
M-Zuber commentedon Jan 6, 2016
Have fun!!