Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efe69733e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| charm.land/bubbletea/v2 v2.1.0 | ||
| charm.land/lipgloss/v2 v2.0.6 | ||
| github.com/basecamp/basecamp-sdk/go v0.29.1 | ||
| github.com/basecamp/basecamp-sdk/go v0.30.0 |
There was a problem hiding this comment.
Refresh the MCP model for the new SDK release
After changing this pin to v0.30.0, internal/mcpserver/model/PROVENANCE.json still records ref: v0.29.1. TestCatalogModelProvenance compares that ref directly with the version in go.mod, so the test suite now fails deterministically and the vendored MCP model omits the new SDK operations. Regenerate the model with scripts/sync-mcp-model.sh and commit the resulting provenance, model, curation, and snapshot updates.
AGENTS.md reference: AGENTS.md:L184-L190
Useful? React with 👍 / 👎.
| charm.land/bubbletea/v2 v2.1.0 | ||
| charm.land/lipgloss/v2 v2.0.6 | ||
| github.com/basecamp/basecamp-sdk/go v0.29.1 | ||
| github.com/basecamp/basecamp-sdk/go v0.30.0 |
There was a problem hiding this comment.
Add commands for cross-project recording moves and copies
The v0.30.0 release being pinned adds SDK operations for moving and copying recordings to another project, but NewRecordingsCmd still registers only list, trash, archive, restore, and visibility, and there are no wrappers or coverage entries for the new methods anywhere in the repository. Users therefore cannot access either newly linked operation through the CLI; add the corresponding commands, registrations, tests, and API coverage before taking this SDK version.
AGENTS.md reference: AGENTS.md:L192-L196
Useful? React with 👍 / 👎.
| charm.land/bubbletea/v2 v2.1.0 | ||
| charm.land/lipgloss/v2 v2.0.6 | ||
| github.com/basecamp/basecamp-sdk/go v0.29.1 | ||
| github.com/basecamp/basecamp-sdk/go v0.30.0 |
There was a problem hiding this comment.
Expose the new project logo operations
This SDK release also introduces the project-logo API, but NewProjectsCmd still exposes wallpaper management without any project-logo subcommand, and the repository contains no project-logo SDK call or coverage row. Consequently the CLI remains unable to read or modify project logos despite linking the service methods; implement and register the corresponding commands and document their coverage as part of this bump.
AGENTS.md reference: AGENTS.md:L192-L196
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
🟡 Changes recommended
The SDK bump leaves model provenance pinned to v0.29.1, failing the provenance test and retaining a stale catalog, while new SDK operations lack CLI implementations and coverage.
2 open issues
What changed in this PR
Updates the CLI’s Basecamp Go SDK dependency from v0.29.1 to v0.30.0, with matching dependency metadata and Nix packaging changes.
Changes:
- Bumps the SDK version and module checksums.
- Updates the recorded SDK revision and timestamp.
- Refreshes the Nix vendor hash for the new dependency.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
nix/package.nix |
Refreshes the dependency vendor hash. |
internal/version/sdk-provenance.json |
Records SDK v0.30.0 and its revision. |
go.sum |
Updates SDK module checksums. |
go.mod |
Pins the SDK dependency to v0.30.0. |
Review effort: Balanced
| charm.land/bubbletea/v2 v2.1.0 | ||
| charm.land/lipgloss/v2 v2.0.6 | ||
| github.com/basecamp/basecamp-sdk/go v0.29.1 | ||
| github.com/basecamp/basecamp-sdk/go v0.30.0 |
| charm.land/bubbletea/v2 v2.1.0 | ||
| charm.land/lipgloss/v2 v2.0.6 | ||
| github.com/basecamp/basecamp-sdk/go v0.29.1 | ||
| github.com/basecamp/basecamp-sdk/go v0.30.0 |
|
main already requires basecamp-sdk/go v0.32.0, so this bump is no longer needed. Closing. |


Bumps
github.com/basecamp/basecamp-sdk/gofrom v0.29.1 to v0.30.0. Opened by coworker's sdk-bump, the backstop for Dependabot: no Dependabot PR 6h after the release. It opens whether or not the bump builds: what broke is the to-do list.Build
scripts/bump-sdk.sh v0.30.0Tests run in this PR's CI.
SDK changes since v0.29.1
Releases: v0.30.0. Read MIGRATING.md for the breaks a clean build won't show.
Other SDK bumps
Summary by cubic
Bumps
github.com/basecamp/basecamp-sdk/gofrom v0.29.1 to v0.30.0, updating the Go module, checksums, SDK provenance, and Nix vendor hash. Build and vet pass.Note that v0.30.0 includes a breaking change to the project logo API; review the SDK's
MIGRATING.mdfor any required adjustments.Written for commit efe6973. Summary will update on new commits.