Repository navigation
Keep a details fold written in Markdown - #1024
Conversation
Basecamp's rich text keeps <details> and <summary>, but the Markdown path escaped them, so an agent could fold the work behind an answer only by hand-writing the whole post as HTML, which the skill tells it not to do. Keep both tags, and say in the basecamp skill and the connector's subagent instructions how to write a fold in Markdown.
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
🟢 Approved
No active review issues block the change to preserve Markdown fold tags.
No open issues 🎉
What changed in this PR
This PR lets Markdown posts retain <details> and <summary> tags, so agents can fold supporting details without writing the entire post as HTML.
Changes:
- Preserve fold tags while continuing to convert the Markdown inside.
- Add regression cases for block and inline folds, retaining unsupported-tag coverage.
- Document fold syntax and instruct connector agents to keep answers, asks, and blockers visible.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
skills/basecamp/SKILL.md |
Documents fold syntax and shortens Mermaid guidance. |
skills/basecamp-connect/subagent.md |
Explains when to fold supporting details and what must remain visible. |
internal/richtext/richtext.go |
Adds details and summary to preserved rich-text tags. |
internal/richtext/richtext_test.go |
Covers block and inline folds and updates unsupported-tag coverage. |
Review effort: Balanced
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
An agent can now fold the work behind an answer from Markdown. A
<details>block typed in Markdown reaches Basecamp as a fold, instead of showing its tags as text.Basecamp's rich text allows
detailsandsummary(bc3doc/api/sections/rich_text.md), and posts written as HTML already fold. The Markdown path escaped both tags, so the only way to fold was to hand-write the whole post as HTML, which the basecamp skill tells agents not to do. In 392 agent posts on 37signals' Basecamp, only 5 folded, all of them HTML, and one post typed in Markdown showed<details>as literal text.What changes:
richTextTagskeepsdetailsandsummary. The Markdown between them still converts, the way it does in any other kept HTML block.Tests: two new cases, one fold with Markdown inside and one written inline. Both fail with the tag change reverted. The old "unsupported inline tag is text" case now uses
<abbr>.bin/cipasses locally.One thing to know: the separators the Markdown path adds put an empty line just inside the top and bottom of an open fold.
Paired with basecamp/coworker#325, which tells agents when to fold. For a person to review and merge.