fix: add fallback default for HOST_DATA_DIR in docker-compose#1049
Open
mehmetkr-31 wants to merge 1 commit intobase:mainfrom
Open
fix: add fallback default for HOST_DATA_DIR in docker-compose#1049mehmetkr-31 wants to merge 1 commit intobase:mainfrom
mehmetkr-31 wants to merge 1 commit intobase:mainfrom
Conversation
If HOST_DATA_DIR is unset, Docker Compose mounts an empty path, creating an anonymous volume that is difficult to locate and easy to accidentally prune. Add a Compose-level fallback of ./data so that chain data is always persisted to a predictable local directory, even when the env variable is missing.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Compose-level fallback (
${HOST_DATA_DIR:-./data}) for the execution service volume mount.Problem
docker-compose.ymlmounts chain data using${HOST_DATA_DIR}:/data. IfHOST_DATA_DIRis unset, Docker Compose expands the variable to an empty string and creates an anonymous volume. This leads to:Solution
Use
${HOST_DATA_DIR:-./data}so that./datais used as a safe fallback when the variable is missing. This aligns with the default already documented in.env.mainnetand.env.sepolia.Impact
HOST_DATA_DIR.Checklist
${NETWORK_ENV:-.env.mainnet}).