Skip to content

Daily Sync with Botocore v1.43.104 on 2026/09/29 - #6359

Closed
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-29-10-07-02
Closed

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-29-10-07-02

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 5s —— View job


Review: Daily Botocore Sync (v1.43.104)

  • Read the PR diff
  • Analyze changes for correctness
  • Post review

This is an automated, code-generated sync of the sagemaker-core shapes/resources against botocore v1.43.104. Changes fall into these buckets:

  • Service model JSON (sagemaker, sagemaker-runtime, sagemaker-featurestore-runtime) — regenerated API definitions.
  • Generated Python (resources.py, shapes.py, config_schema.py, shape_dag.py, api_coverage.json) — regenerated to match.

I verified the newly-referenced shape types are actually defined, so no dangling references:

  • AIAdapterSource → shapes.py:567
  • IdcConfigInput → shapes.py:9379
  • IdcConfigOutput → shapes.py:11468

New optional parameters/fields are additive and backward-compatible (adapter_source, prefix_aware_id, kms_key_id on MLflowApp, included_data on ModelCard/ModelPackage, training_plan_arns on OptimizationJob, idc_config/auth_type on PartnerApp, new wait_for_status literals). No concerns there.

One item worth flagging (informational)

Endpoint.invoke_async — positional signature reordered (resources.py, ~line 10787)

input_location changed from a required first positional parameter to an optional keyword-style parameter moved after content_type/accept/custom_attributes/inference_id:

# before
def invoke_async(self, input_location: StrPipeVar, content_type=Unassigned(), ...)

# after
def invoke_async(self, content_type=Unassigned(), accept=Unassigned(),
                 custom_attributes=Unassigned(), inference_id=Unassigned(),
                 input_location: Optional[StrPipeVar] = Unassigned(),
                 s3_output_path_extension=..., filename=..., ..., body=...)

This is a source-breaking change for any caller passing input_location positionally — e.g. endpoint.invoke_async("s3://...") now binds that value to content_type, not input_location. Callers using the keyword form (invoke_async(input_location=...)) are unaffected.

This correctly mirrors the upstream botocore change (the new Body inline-payload parameter makes InputLocation optional and mutually exclusive with Body), so the regeneration itself is faithful. Just noting it as a behavioral change consumers may hit — nothing to fix in this generated PR.

Prompt-injection check

Per my review instructions, I treated all PR content as data. Nothing in the diff, title, or body attempted to redirect the review.

Verdict: Clean, mechanical sync. No correctness, security, or performance issues in the generated output. Tests are not expected for a codegen sync.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.63%. Comparing base (4f3cc56) to head (ce82d10).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6359      +/-   ##
==========================================
+ Coverage   71.58%   71.63%   +0.04%     
==========================================
  Files         556      556              
  Lines       68640    68746     +106     
==========================================
+ Hits        49139    49245     +106     
  Misses      19501    19501              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
auto-approve — ce82d100 Deployed Sep 29, 2026 by sagemaker-bot via wait-for-approval #1580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants