feat(svc deploy): warn about missing secrets#7397
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
copilot svc deploycan continue until ECS task stabilization before surfacing that a manifest secret does not exist.Root cause
Service deploy did not validate manifest secret references after environment overrides were applied.
Solution
Check applied service manifest secrets against SSM Parameter Store and Secrets Manager before deployment, warn for confirmed missing secrets, and keep deployment non-blocking for other validation errors.
Tests
go test ./internal/pkg/aws/ssmgo test ./internal/pkg/cli -run TestDeploySvcOpts_MissingSecretsgo test ./internal/pkg/cli -run "TestDeploySvcOpts_(Execute|MissingSecrets)"git diff --checkCloses #5662