Repository navigation
Conversation
… the Smithy path Master's C2J path generates the endpoint provider from endpoint-bdd-1.json and runs DefaultReadWriteTimeoutExemptionProcessor in its customization chain. The Smithy path did neither, so a migrated service would get the rule-tree endpoint provider and lose its default read/write timeout. - AddSmithyEndpoints reads the @endpointBdd trait into EndpointBddModel, and SmithyIntermediateModelBuilder passes it to the intermediate model. - SmithyIntermediateModelPostprocessor runs DefaultReadWriteTimeoutExemptionProcessor last, as the C2J chain does.
The not-exempt case passes with or without the postprocessor change and is already covered by DefaultReadWriteTimeoutExemptionProcessorTest.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When merging the master to the feature brach, there are two gaps that need special handling:
endpoint-bdd-1.jsoninstead of the rule treeDefaultReadWriteTimeoutExemptionProcessor.This PR closes these two gap for smithy path
Modifications
AddSmithyEndpoints: read the@smithy.rules#endpointBddtrait intoEndpointBddModel.SmithyIntermediateModelBuilder: pass that model to the intermediate model.SmithyIntermediateModelPostprocessor: runDefaultReadWriteTimeoutExemptionProcessorlast, as the same position as in the C2J chain.Testing
@endpointBddtrait equalsendpoint-bdd-1.jsonof the current release.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.AI tools
License