Repository navigation
Fix parallel multipart download recording part 1 too late - #7504
Open
S-Saranya1 wants to merge 2 commits into
Open
S-Saranya1 wants to merge 2 commits into
S-Saranya1 wants to merge 2 commits into
Conversation
| getObjectResponse = res; | ||
| MultipartDownloadUtils.multipartDownloadResumeContext(getObjectRequest) | ||
| .ifPresent(ctx -> { | ||
| ctx.addCompletedPart(1); |
Contributor
There was a problem hiding this comment.
Could pausing at this point capture part 1 as completed before response and totalParts are available? On resume, would that skip part 1 while leaving totalPartsFuture unresolved, preventing the remaining requests from starting?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
With a multipart-enabled S3AsyncClient, a parallel multipart download could complete with a null response. When part 1 finished, the remaining parts were started before part 1's response was saved. If they all finished first, the download returned null, and S3TransferManager.downloadFile then reported a failure even though every part downloaded. A pause in the same window could also produce a resume token missing part 1.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License