CBOR codegen for enum-keyed maps in CborEncodeValue template#3799
Merged
CBOR codegen for enum-keyed maps in CborEncodeValue template#3799
Conversation
The CBOR encode template always serialized map keys with .c_str(), assuming string keys. This fails to compile when the map key is an enum type (e.g. GetEntitlementFilterName in Marketplace Entitlement). Add a conditional to use the enum mapper (GetNameFor...) when the map key is an enum, matching the existing pattern in the JSON template.
sbaluja
approved these changes
Apr 16, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The CBOR encode template always serialized map keys with .c_str(), assuming string keys. This fails to compile when the map key is an enum type (e.g. GetEntitlementFilterName in Marketplace Entitlement).
Add a conditional to use the enum mapper (GetNameFor...) when the map key is an enum, matching the existing pattern in the JSON template.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.