fix: add retry to pyinstaller docker build and fix terraform install script#8886
Merged
roger-zhangg merged 5 commits intodevelopfrom Apr 2, 2026
Merged
Conversation
…script - Add bash retry loop (3 attempts) to docker run step in validate_pyinstaller.yml - Fix install-terraform.sh silent failure caused by set -e + pipefail killing the script when grep exits non-zero in the version fetch pipeline
Member
Author
Vandita2020
previously approved these changes
Apr 1, 2026
valerena
previously approved these changes
Apr 1, 2026
… action - Use hashicorp/setup-terraform@v4.0.0 (pinned to commit hash) in integration-tests.yml instead of the custom install script - Remove tests/install-terraform.sh
The wrapper intercepts terraform stdout/stderr which can interfere with SAM CLI's subprocess calls to terraform. Disabling it ensures the raw terraform binary is used directly.
valerena
approved these changes
Apr 2, 2026
Vandita2020
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
docker runstep for building PyInstaller in the manylinux container, handling transient failures.hashicorp/setup-terraformgithub action