Skip to content

fix(ci): add retry and debug logging for Windows InvalidSignatureException#8864

Merged
roger-zhangg merged 1 commit intodevelopfrom
invalid_sig_fix
Apr 3, 2026
Merged

fix(ci): add retry and debug logging for Windows InvalidSignatureException#8864
roger-zhangg merged 1 commit intodevelopfrom
invalid_sig_fix

Conversation

@roger-zhangg
Copy link
Copy Markdown
Member

@roger-zhangg roger-zhangg commented Mar 27, 2026

Problem

The setup_testing_resources.py step intermittently fails (~10% of the time) on Windows GitHub runners with InvalidSignatureException when invoking the credential distribution Lambda. This never happens on Linux runners.
Example: https://github.com/aws/aws-sam-cli/actions/runs/23665127474/job/68945043702

Changes

  • tests/get_testing_resources.py: Explicitly .strip() AWS credentials before passing to boto3 client to guard against any trailing whitespace/\r on Windows
  • tests/setup_testing_resources.py: Added retry loop (3 attempts, 5s delay) around credential fetch, and added UTC clock logging on each attempt to help diagnose whether clock skew is the root cause

@roger-zhangg roger-zhangg requested a review from a team as a code owner March 27, 2026 21:59
@roger-zhangg
Copy link
Copy Markdown
Member Author

@roger-zhangg roger-zhangg added this pull request to the merge queue Apr 3, 2026
Merged via the queue into develop with commit 6542a3a Apr 3, 2026
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants