Conversation
AndrewAsseily
approved these changes
Nov 26, 2025
Contributor
AndrewAsseily
left a comment
AndrewAsseily
left a comment
There was a problem hiding this comment.
LGTM 🚢 , assuming CI passes.
Just 2 small, non-blocking nits.
| --hash=sha256:deb3742856699d456382d38883fe8d19903ee70f968083a3497c85491069de4f \ | ||
| --hash=sha256:e27509fa46d44c9c0e6cbe511c82126b1dff95f9b2cb77428f75a5e2c1dc85c7 \ | ||
| --hash=sha256:e28c65bbc265fb3a2f3fa8924ab098ed230732fc01eea255f3c1f1da5a30396f | ||
| # via awscli (D:/a/aws-cli/aws-cli/pyproject.toml) |
Contributor
There was a problem hiding this comment.
Non-blocking nit: Noticed the generated lockfiles now reference D:/a/aws-cli/aws-cli/pyproject.toml instead of (pyproject.toml) in the comments. I get that this comes from the GA environment, but the windows path leaking into the files feels a bit odd.
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "type": "enhancement", | |||
| "category": "crt", | |||
Contributor
There was a problem hiding this comment.
Non-blocking nit: One changelog entry uses category awscrt and the other crt. Might be worth making them consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
multipart_chunksizeisn't explicitly provided and the resolved transfer client is CRT, then set it toNoneinstead of the 8MiB default and let CRT dynamically determine the part size.This PR also updates the awscrt version to 0.29.0.