Defer resolution of binary_stdin - #3034
Merged
JordonPhillips merged 2 commits intoDec 13, 2017
Merged
Conversation
This replaces the static `binary_stdin` in compat.py with a function to get the binary version of standard input. This function will raise a more end-user useful error message if stdin isn't available in the current process.
JordonPhillips
added
pr:needs-review
joguSD
approved these changes
Dec 12, 2017
Codecov Report
@@ Coverage Diff @@
## develop #3034 +/- ##
===========================================
- Coverage 95.76% 95.74% -0.03%
===========================================
Files 165 165
Lines 12578 12589 +11
===========================================
+ Hits 12045 12053 +8
- Misses 533 536 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the static
binary_stdinin compat.py with a functionto get the binary version of standard input. This function will raise
a more end-user useful error message if stdin isn't available in the
current process. Since the function only gets called when stdin is
needed, users will be able to run the CLI without stdin for all the
commands that don't use it. See #2518 for context on the original
issue.
Resolves #2990
Closes #2991