Skip to content

Expose --delay and --max-attempts for wait commands (#1295)#10224

Open
minjcho wants to merge 2 commits intoaws:v2from
minjcho:expose-waiter-delay-max-attempts
Open

Expose --delay and --max-attempts for wait commands (#1295)#10224
minjcho wants to merge 2 commits intoaws:v2from
minjcho:expose-waiter-delay-max-attempts

Conversation

@minjcho
Copy link
Copy Markdown

@minjcho minjcho commented Apr 15, 2026

Issue #, if available:
Fixes #1295

Description of changes:

  • Add --delay and --max-attempts arguments to waiter commands.
  • Pass the provided values through WaiterConfig when invoking waiter.wait().
  • Update waiter help text to document the new options.
  • Add unit coverage for argument parsing, help output, and waiter config injection.

Description of tests:

  • Added unit tests covering argument parsing, help output, and waiter config injection.
  • Ran python -m pytest tests/unit/customizations/test_waiters.py -q — all pass.
  • Succeeded manual testing described below.

Manual testing:

Verified the new flags appear in the generated help output:

aws ec2 wait instance-running help

I confirmed that [--delay <value>] and [--max-attempts <value>] are listed in the synopsis and documented in the options section.

Then I ran:

aws ec2 wait instance-running --instance-ids <YOUR_INSTANCE_ID> --delay 5 --max-attempts 10

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant