Skip to content

fix(tc): address failing typechecker by completing test interface - #2188

Merged
Hweinstock merged 1 commit into
aws:refactorfrom
Hweinstock:fix/tsc
Sep 3, 2026
Merged

fix(tc): address failing typechecker by completing test interface#2188
Hweinstock merged 1 commit into
aws:refactorfrom
Hweinstock:fix/tsc

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

typechecker failing. https://github.com/aws/agentcore-cli/actions/runs/33786276059/job/100751718167

Solution

  • add missing method on test interface.

Verification

bun run typecheck && bun test src/core/project/backends/ passes.

@github-actions github-actions Bot added the size/xs PR size: XS label Sep 3, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 3, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 3, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Minimal, correct fix: the fake ProjectBackend in buildDeploy.screen.test.tsx was missing resolveProjectResources, which is required by the interface (see src/core/project/backends/types.ts:41). The added stub returning [] matches the same pattern used in the sibling test files (deploy/index.test.ts, build/index.test.ts, invoke/index.test.tsx, status/index.test.ts). No production code, telemetry, or mocking concerns apply here. Safe to merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 3, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (2e30e1f) to head (8c631f6).

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2188   +/-   ##
=========================================
  Coverage     97.13%   97.13%           
=========================================
  Files           541      541           
  Lines         37618    37618           
=========================================
  Hits          36542    36542           
  Misses         1076     1076           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hweinstock
Hweinstock marked this pull request as ready for review September 3, 2026 18:11
@Hweinstock
Hweinstock merged commit 9d75a50 into aws:refactor Sep 3, 2026
22 of 26 checks passed
@Hweinstock
Hweinstock deleted the fix/tsc branch September 3, 2026 18:13
This was referenced Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants