fix(tc): address failing typechecker by completing test interface - #2188
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Minimal, correct fix: the fake ProjectBackend in buildDeploy.screen.test.tsx was missing resolveProjectResources, which is required by the interface (see src/core/project/backends/types.ts:41). The added stub returning [] matches the same pattern used in the sibling test files (deploy/index.test.ts, build/index.test.ts, invoke/index.test.tsx, status/index.test.ts). No production code, telemetry, or mocking concerns apply here. Safe to merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2188 +/- ##
=========================================
Coverage 97.13% 97.13%
=========================================
Files 541 541
Lines 37618 37618
=========================================
Hits 36542 36542
Misses 1076 1076 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Problem
typechecker failing. https://github.com/aws/agentcore-cli/actions/runs/33786276059/job/100751718167
Solution
Verification
bun run typecheck && bun test src/core/project/backends/passes.