-
Notifications
You must be signed in to change notification settings - Fork 92
feat: gateway policy generate #2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6452e76
feat(core): PolicyClient generates Cedar from a prompt against a depl…
tejaskash 6b1f69a
feat(gateway): gateway policy generate turns a prompt into Cedar
tejaskash 7ad8a2d
refactor(policy): inline one-use finding type and collapse the no-sta…
tejaskash a07936d
test(policy): record golden fixtures for gateway policy generate and …
tejaskash ce49534
feat(policy): print only the Cedar document; findings stay in --json
tejaskash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| import { | ||
| GetGatewayCommand, | ||
| ListPolicyGenerationAssetsCommand, | ||
| StartPolicyGenerationCommand, | ||
| waitForPolicyGenerationCompleted, | ||
| type GetPolicyGenerationCommandOutput, | ||
| } from "@aws-sdk/client-bedrock-agentcore-control"; | ||
| import { WaiterState } from "@smithy/core/client"; | ||
| import { AgentCoreCLIError, ERROR_SOURCE, InputValidationError, NetworkingError } from "../errors"; | ||
| import type { | ||
| CorePolicyClient, | ||
| GeneratedPolicy, | ||
| GeneratePolicyInput, | ||
| PolicyGenerationResult, | ||
| } from "../handlers/gateway/policy/types"; | ||
| import type { Logger } from "../logging"; | ||
| import type { ProgressEvent } from "../tui/progress"; | ||
| import type { AwsClients, CoreOptions } from "./types"; | ||
| import { toClientConfig } from "./utils"; | ||
|
|
||
| export type PolicyGenerationWait = { | ||
| maxWaitTime: number; | ||
| minDelay: number; | ||
| maxDelay: number; | ||
| }; | ||
|
|
||
| const DEFAULT_WAIT: PolicyGenerationWait = { maxWaitTime: 60, minDelay: 2, maxDelay: 5 }; | ||
|
|
||
| function resourceIdFromArn(value: string): string { | ||
| return value.startsWith("arn:") ? value.slice(value.lastIndexOf("/") + 1) : value; | ||
| } | ||
|
|
||
| export class PolicyClient implements CorePolicyClient { | ||
| constructor( | ||
| private readonly clients: AwsClients, | ||
| private readonly logger: Logger, | ||
| private readonly wait: PolicyGenerationWait = DEFAULT_WAIT, | ||
| ) {} | ||
|
|
||
| async *generatePolicy( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OOS but a lot of our coreClient function's don't yield helpful messages like in here. We should work on this later.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed |
||
| input: GeneratePolicyInput, | ||
| options: CoreOptions, | ||
| ): AsyncGenerator<ProgressEvent, PolicyGenerationResult> { | ||
| const control = this.clients.control(toClientConfig(options)); | ||
| const gatewayId = resourceIdFromArn(input.gatewayId); | ||
|
|
||
| yield { type: "step", message: `Resolving gateway ${gatewayId}` }; | ||
| const gateway = await control.send(new GetGatewayCommand({ gatewayIdentifier: gatewayId })); | ||
| const gatewayArn = gateway.gatewayArn!; | ||
| const engine = input.policyEngineId ?? gateway.policyEngineConfiguration?.arn; | ||
| if (!engine) { | ||
| throw new InputValidationError( | ||
| `gateway '${gatewayId}' has no Policy Engine attached; pass --policy-engine-id`, | ||
| ); | ||
| } | ||
| const policyEngineId = resourceIdFromArn(engine); | ||
|
|
||
| yield { type: "step", message: `Starting policy generation ${input.name}` }; | ||
| const started = await control.send( | ||
| new StartPolicyGenerationCommand({ | ||
| policyEngineId, | ||
| resource: { arn: gatewayArn }, | ||
| content: { rawText: input.prompt }, | ||
| name: input.name, | ||
| }), | ||
| ); | ||
| const policyGenerationId = started.policyGenerationId!; | ||
| const meta = { policyGenerationId, policyEngineId }; | ||
|
|
||
| yield { type: "step", message: "Waiting for generation to complete" }; | ||
| const waited = await waitForPolicyGenerationCompleted( | ||
| { client: control, ...this.wait }, | ||
| { policyEngineId, policyGenerationId }, | ||
| ); | ||
| this.logger.debug(`policy generation ${policyGenerationId} waiter state: ${waited.state}`); | ||
| if (waited.state === WaiterState.TIMEOUT) { | ||
| throw new NetworkingError( | ||
| `policy generation '${policyGenerationId}' did not finish within ${this.wait.maxWaitTime}s; ` + | ||
| "it may still complete on the service", | ||
| { meta }, | ||
| ); | ||
| } | ||
| if (waited.state !== WaiterState.SUCCESS) { | ||
| const reasons = (waited.reason as GetPolicyGenerationCommandOutput | undefined) | ||
| ?.statusReasons; | ||
| throw new AgentCoreCLIError( | ||
| `policy generation '${policyGenerationId}' failed: ${reasons?.join("; ") ?? waited.state}`, | ||
| { source: ERROR_SOURCE.SERVICE, meta }, | ||
| ); | ||
| } | ||
|
|
||
| yield { type: "step", message: "Reading generated policies" }; | ||
| const policies: GeneratedPolicy[] = []; | ||
| let nextToken: string | undefined; | ||
| do { | ||
| const page = await control.send( | ||
| new ListPolicyGenerationAssetsCommand({ policyEngineId, policyGenerationId, nextToken }), | ||
| ); | ||
| for (const asset of page.policyGenerationAssets ?? []) { | ||
| policies.push({ | ||
| statement: asset.definition?.cedar?.statement ?? asset.definition?.policy?.statement, | ||
| findings: (asset.findings ?? []).map((finding) => ({ | ||
| type: finding.type ?? "UNKNOWN", | ||
| description: finding.description ?? "", | ||
| })), | ||
| }); | ||
| } | ||
| nextToken = page.nextToken; | ||
| } while (nextToken); | ||
|
|
||
| if (!policies.some((policy) => policy.statement)) { | ||
| const findings = policies | ||
| .flatMap((policy) => policy.findings) | ||
| .map((finding) => `[${finding.type}] ${finding.description}`) | ||
| .join("; "); | ||
| throw new AgentCoreCLIError( | ||
| `the prompt could not be translated into a Cedar policy${findings ? `: ${findings}` : ""}`, | ||
| { source: ERROR_SOURCE.SERVICE, meta }, | ||
| ); | ||
| } | ||
| return { policyGenerationId, policyEngineId, gatewayArn, policies }; | ||
| } | ||
| } | ||
19 changes: 19 additions & 0 deletions
19
src/handlers/gateway/__fixtures__/policy/GetGatewayCommand.5513677d251db507.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "gatewayArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-bare-xl0dy3pq5h", | ||
| "gatewayId": "policygene2e-bare-xl0dy3pq5h", | ||
| "createdAt": { | ||
| "$date": "2026-09-02T19:50:44.028Z" | ||
| }, | ||
| "updatedAt": { | ||
| "$date": "2026-09-02T19:50:44.841Z" | ||
| }, | ||
| "status": "READY", | ||
| "name": "PolicyGenE2E-bare", | ||
| "authorizerType": "NONE", | ||
| "gatewayUrl": "https://policygene2e-bare-xl0dy3pq5h.gateway.bedrock-agentcore.us-west-2.amazonaws.com", | ||
| "description": "Gateway for PolicyGenE2E-bare", | ||
| "roleArn": "arn:aws:iam::887863153624:role/AgentCore-PolicyGenE2E-de-McpGatewayBareRole58BAE2C-jSYHioxsHFHU", | ||
| "workloadIdentityDetails": { | ||
| "workloadIdentityArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:workload-identity-directory/default/workload-identity/policygene2e-bare-xl0dy3pq5h" | ||
| } | ||
| } |
23 changes: 23 additions & 0 deletions
23
src/handlers/gateway/__fixtures__/policy/GetGatewayCommand.aaf1bce123157e06.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "gatewayArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-tools-zhijfh6m5z", | ||
| "gatewayId": "policygene2e-tools-zhijfh6m5z", | ||
| "createdAt": { | ||
| "$date": "2026-09-02T19:30:56.123Z" | ||
| }, | ||
| "updatedAt": { | ||
| "$date": "2026-09-02T19:30:56.809Z" | ||
| }, | ||
| "status": "READY", | ||
| "name": "PolicyGenE2E-tools", | ||
| "authorizerType": "NONE", | ||
| "gatewayUrl": "https://policygene2e-tools-zhijfh6m5z.gateway.bedrock-agentcore.us-west-2.amazonaws.com", | ||
| "description": "Gateway for PolicyGenE2E-tools", | ||
| "roleArn": "arn:aws:iam::887863153624:role/AgentCore-PolicyGenE2E-de-McpGatewayToolsRole1D55B5-WhvuoXGDoNYC", | ||
| "policyEngineConfiguration": { | ||
| "arn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:policy-engine/PolicyGenE2E_Guardrails-gn5jf72o3t", | ||
| "mode": "LOG_ONLY" | ||
| }, | ||
| "workloadIdentityDetails": { | ||
| "workloadIdentityArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:workload-identity-directory/default/workload-identity/policygene2e-tools-zhijfh6m5z" | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
src/handlers/gateway/__fixtures__/policy/GetPolicyGenerationCommand.7ae2ce2725ceedf1.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "policyEngineId": "PolicyGenE2E_Guardrails-gn5jf72o3t", | ||
| "policyGenerationId": "golden_forbid_1788379436724-6vfaj00xfb", | ||
| "name": "golden_forbid_1788379436724", | ||
| "policyGenerationArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:policy-engine/PolicyGenE2E_Guardrails-gn5jf72o3t/policy-generation/golden_forbid_1788379436724-6vfaj00xfb", | ||
| "resource": { | ||
| "arn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-tools-zhijfh6m5z" | ||
| }, | ||
| "createdAt": { | ||
| "$date": "2026-09-02T20:03:57.296Z" | ||
| }, | ||
| "updatedAt": { | ||
| "$date": "2026-09-02T20:04:08.119Z" | ||
| }, | ||
| "status": "GENERATED", | ||
| "statusReasons": [] | ||
| } |
17 changes: 17 additions & 0 deletions
17
src/handlers/gateway/__fixtures__/policy/GetPolicyGenerationCommand.81eab1512df1bb7e.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "policyEngineId": "PolicyGenE2E_Guardrails-gn5jf72o3t", | ||
| "policyGenerationId": "golden_untranslatable_1788379436724-zwadwgy5xq", | ||
| "name": "golden_untranslatable_1788379436724", | ||
| "policyGenerationArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:policy-engine/PolicyGenE2E_Guardrails-gn5jf72o3t/policy-generation/golden_untranslatable_1788379436724-zwadwgy5xq", | ||
| "resource": { | ||
| "arn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-tools-zhijfh6m5z" | ||
| }, | ||
| "createdAt": { | ||
| "$date": "2026-09-02T20:04:26.137Z" | ||
| }, | ||
| "updatedAt": { | ||
| "$date": "2026-09-02T20:04:34.371Z" | ||
| }, | ||
| "status": "GENERATED", | ||
| "statusReasons": [] | ||
| } |
17 changes: 17 additions & 0 deletions
17
src/handlers/gateway/__fixtures__/policy/GetPolicyGenerationCommand.c3cc22b88924256e.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "policyEngineId": "PolicyGenE2E_Guardrails-gn5jf72o3t", | ||
| "policyGenerationId": "golden_permit_1788379436724-ps3sdu9w0d", | ||
| "name": "golden_permit_1788379436724", | ||
| "policyGenerationArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:policy-engine/PolicyGenE2E_Guardrails-gn5jf72o3t/policy-generation/golden_permit_1788379436724-ps3sdu9w0d", | ||
| "resource": { | ||
| "arn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-tools-zhijfh6m5z" | ||
| }, | ||
| "createdAt": { | ||
| "$date": "2026-09-02T20:04:08.865Z" | ||
| }, | ||
| "updatedAt": { | ||
| "$date": "2026-09-02T20:04:19.851Z" | ||
| }, | ||
| "status": "GENERATED", | ||
| "statusReasons": [] | ||
| } |
19 changes: 19 additions & 0 deletions
19
...dlers/gateway/__fixtures__/policy/ListPolicyGenerationAssetsCommand.7ae2ce2725ceedf1.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "policyGenerationAssets": [ | ||
| { | ||
| "policyGenerationAssetId": "golden_forbid_1788379436724-9nhse8m4wg", | ||
| "rawTextFragment": "forbid IAM principals from calling any tool on this gateway", | ||
| "findings": [ | ||
| { | ||
| "type": "DENY_ALL", | ||
| "description": "Overly Restrictive: The generated policy denies all actions for all principals. Confirm that full restriction is intended before applying this policy." | ||
| } | ||
| ], | ||
| "definition": { | ||
| "policy": { | ||
| "statement": "forbid (principal is AgentCore::IamEntity, action, resource == AgentCore::Gateway::\"arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-tools-zhijfh6m5z\");" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
24 changes: 24 additions & 0 deletions
24
...dlers/gateway/__fixtures__/policy/ListPolicyGenerationAssetsCommand.81eab1512df1bb7e.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "policyGenerationAssets": [ | ||
| { | ||
| "policyGenerationAssetId": "golden_untranslatable_1788379436724-s0kq76o_vl", | ||
| "rawTextFragment": "Forbid calling any tool whose name contains delete.", | ||
| "findings": [ | ||
| { | ||
| "type": "INVALID", | ||
| "description": "Non-translatable: cannot be expressed in Dogwood" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "policyGenerationAssetId": "golden_untranslatable_1788379436724-v9e46aqhnp", | ||
| "rawTextFragment": "Permit everyone to list tools.", | ||
| "findings": [ | ||
| { | ||
| "type": "INVALID", | ||
| "description": "Non-translatable: cannot be expressed in Dogwood" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
19 changes: 19 additions & 0 deletions
19
...dlers/gateway/__fixtures__/policy/ListPolicyGenerationAssetsCommand.c3cc22b88924256e.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "policyGenerationAssets": [ | ||
| { | ||
| "policyGenerationAssetId": "golden_permit_1788379436724-1jag4xr0sz", | ||
| "rawTextFragment": "permit IAM principals to call any tool on this gateway", | ||
| "findings": [ | ||
| { | ||
| "type": "ALLOW_ALL", | ||
| "description": "Overly Permissive: The generated policy permits all actions for all principals. Confirm that unrestricted access is intended before applying this policy" | ||
| } | ||
| ], | ||
| "definition": { | ||
| "policy": { | ||
| "statement": "permit (principal is AgentCore::IamEntity, action, resource == AgentCore::Gateway::\"arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-tools-zhijfh6m5z\");" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
17 changes: 17 additions & 0 deletions
17
src/handlers/gateway/__fixtures__/policy/StartPolicyGenerationCommand.3add87bfdfde5e9e.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "policyEngineId": "PolicyGenE2E_Guardrails-gn5jf72o3t", | ||
| "policyGenerationId": "golden_untranslatable_1788379436724-zwadwgy5xq", | ||
| "name": "golden_untranslatable_1788379436724", | ||
| "policyGenerationArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:policy-engine/PolicyGenE2E_Guardrails-gn5jf72o3t/policy-generation/golden_untranslatable_1788379436724-zwadwgy5xq", | ||
| "resource": { | ||
| "arn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-tools-zhijfh6m5z" | ||
| }, | ||
| "createdAt": { | ||
| "$date": "2026-09-02T20:04:26.137Z" | ||
| }, | ||
| "updatedAt": { | ||
| "$date": "2026-09-02T20:04:26.137Z" | ||
| }, | ||
| "status": "GENERATING", | ||
| "statusReasons": [] | ||
| } |
6 changes: 6 additions & 0 deletions
6
src/handlers/gateway/__fixtures__/policy/StartPolicyGenerationCommand.c16bc5832065a273.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "$error": { | ||
| "name": "ValidationException", | ||
| "message": "1 validation error detected. Value at '/policyEngineId' failed to satisfy constraint: Member must satisfy regular expression pattern: ^[A-Za-z][A-Za-z0-9_]*-[a-z0-9_]{10}$" | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
src/handlers/gateway/__fixtures__/policy/StartPolicyGenerationCommand.cbe8967379451f9d.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "policyEngineId": "PolicyGenE2E_Guardrails-gn5jf72o3t", | ||
| "policyGenerationId": "golden_permit_1788379436724-ps3sdu9w0d", | ||
| "name": "golden_permit_1788379436724", | ||
| "policyGenerationArn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:policy-engine/PolicyGenE2E_Guardrails-gn5jf72o3t/policy-generation/golden_permit_1788379436724-ps3sdu9w0d", | ||
| "resource": { | ||
| "arn": "arn:aws:bedrock-agentcore:us-west-2:887863153624:gateway/policygene2e-tools-zhijfh6m5z" | ||
| }, | ||
| "createdAt": { | ||
| "$date": "2026-09-02T20:04:08.865Z" | ||
| }, | ||
| "updatedAt": { | ||
| "$date": "2026-09-02T20:04:08.865Z" | ||
| }, | ||
| "status": "GENERATING", | ||
| "statusReasons": [] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: OOS but there must be a shared util function for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed