Skip to content

fix(memory): adjust import to use new path - #1961

Merged
aidandaly24 merged 1 commit into
aws:refactorfrom
Hweinstock:fix/failing-ci
Aug 10, 2026
Merged

fix(memory): adjust import to use new path#1961
aidandaly24 merged 1 commit into
aws:refactorfrom
Hweinstock:fix/failing-ci

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

Typecheck is failing on refactor branch

Run bun run typecheck
$ tsc --noEmit
src/components/ui/data-table/columnWidths.test.ts(9,10): error TS2305: Module '"../../../handlers/memory/list/screen"' has no exported member 'memoryColumns'.
src/components/ui/data-table/columnWidths.test.ts(79,33): error TS7006: Parameter 'column' implicitly has an 'any' type.
src/components/ui/data-table/columnWidths.test.ts(79,41): error TS7006: Parameter 'index' implicitly has an 'any' type.
src/components/ui/data-table/columnWidths.test.ts(109,44): error TS7006: Parameter 'column' implicitly has an 'any' type.

Solution

adjust import path.

Testing

bun run typecheck.

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 10, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review August 10, 2026 15:36
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.69%. Comparing base (f1a35cb) to head (73518bf).

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #1961      +/-   ##
============================================
+ Coverage     96.64%   96.69%   +0.04%     
============================================
  Files           291      291              
  Lines         16012    16012              
============================================
+ Hits          15475    15483       +8     
+ Misses          537      529       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 10, 2026
@aidandaly24
aidandaly24 merged commit 7e29eda into aws:refactor Aug 10, 2026
10 of 11 checks passed
@Hweinstock
Hweinstock deleted the fix/failing-ci branch August 10, 2026 15:39
This was referenced Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants