feat(memory): add read-only Memory TUI - #1878
Conversation
github-actions
Bot
added
agentcore-harness-reviewing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #1878 +/- ##
============================================
+ Coverage 95.86% 95.89% +0.03%
============================================
Files 198 201 +3
Lines 9352 9505 +153
============================================
+ Hits 8965 9115 +150
- Misses 387 390 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Unrelated but I will look into this failure for AI reviewer separately. It now throws a new error. https://github.com/aws/agentcore-cli/actions/runs/30582321369/job/91005460337?pr=1878
|
github-actions
Bot
added
agentcore-harness-reviewing
|
Fixed the reviewer ^ |
github-actions
Bot
added
agentcore-harness-reviewing
aidandaly24
left a comment
aidandaly24
left a comment
There was a problem hiding this comment.
I have no comments, approved.
| navigate(-1); | ||
| return; | ||
| } | ||
| if (input === "r" && detail.isError) { |
There was a problem hiding this comment.
q: do we want to allow the user to refresh even if there isn't an error? (ex. maybe something changed and they want to check).
This looks consistent with https://github.com/aws/agentcore-cli/blob/refactor/src/handlers/runtime/get/screen.tsx#L48 so just curious what behavior we want.
There was a problem hiding this comment.
nice catch I think we would want that right? maybe I created a new resource while the TUI screen was open and I just want to refresh it to see if it shows up.
Let me add that quickly in a follow up in both places
| import { useQuery } from "@tanstack/react-query"; | ||
| import { Box, Text, useInput } from "ink"; | ||
| import { useNavigate, useParams } from "react-router"; | ||
| import { JsonDetail } from "../../../components/JsonDetail"; |
There was a problem hiding this comment.
love to see us using so many common components!
4 participants
This PR asds read-only TUI screens for listing and inspecting AgentCore Memories.
Manually tested all flows.
This reuses the shared DataTable through PaginatedTablePicker, with #1845 ’s column configuration