fix(cdk): exclude ResolverQueryLoggingConfig from resource tags#222
Merged
Conversation
CfnResolverQueryLoggingConfig treats tag changes as requiring replacement, cascading to the per-VPC association which fails due to the one-association-per-VPC uniqueness constraint. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Association depends on the Config's physical ID. Even though PR #221 excluded the Config from tagging (preventing its replacement), the Association's CloudFormation state still references a stale Config ID from a prior failed replacement. Adding it to excludeResourceTypes prevents any future tag-induced update attempt on either resource. Part of #221, parent issue #229. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
scottschreckengaust
force-pushed
the
fix/221-exclude-querylog-from-tags
branch
from
0fdf9d2 to
7ce5cf9
Compare
krokoko
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AWS::Route53Resolver::ResolverQueryLoggingConfigfrom stack-levelTags.of()callsUPDATE_FAILEDon every deploy wheregithub:sha(or any tag value) changesProblem
CfnResolverQueryLoggingConfigis a create-only resource — ALL property changes (including Tags) trigger CloudFormation replacement. This cascades:ResolverQueryLogConfigId→ triggers replacementInvalidRequestTrade-off
This one resource type won't have tag parity with the rest of the stack. The associated LogGroup, VPC, and all other resources still get full tags. The QueryLogConfig is identifiable by its fixed
Nameproperty (agent-dns-query-log).Test plan
npx tsc --noEmit— clean compilejest dns-firewall— 19/19 tests passcdk synth— confirmsDnsFirewallQueryLogConfig4CCCED66has noTagspropertyUPDATE_FAILEDCloses #221
🤖 Generated with Claude Code