Tech debt: Use dispatch dict for proxy event conversion

[leandrodamascena]

Why is this needed?

_to_proxy_event() has 7 sequential if/return statements (suppressed with # noqa PLR0911). A simple dict mapping ProxyEventType to event class replaces all of them.

Steps:

1. Create PROXY_EVENT_MAP: dict[ProxyEventType, type[BaseProxyEvent]] at module level
2. Replace the if-chain with a dict lookup
3. Remove the noqa

Which area does this relate to?

Event Handler - REST API

Suggestion

No response

Acknowledgment

• This request meets Powertools for AWS Lambda (Python) Tenets
• Should this be considered in other Powertools for AWS Lambda languages? i.e. Java, TypeScript, and .NET

[svozza]

Would using pattern matching here instead of if/else still have the same problem because it would still involve a lot of returns?

[leandrodamascena]

Hey @svozza,! I actually considered match/case first since we already require Python 3.10+. But honestly, it would be a lateral swap here - we would need a match for each case, no? So I'd end up with roughly the same verbosity, just different syntax.

A dict mapping is better I think. It because it eliminates the structural repetition code block. I can map ProxyEventType to a (log_message, event_class) tuple, for example, and reduce the whole method to a lookup for a return based on the class. That also lets us drop the # noqa PLR0911 and avoid a lot of code branch.

Am I missing something here?

[svozza]

No, don't think you're missing anything, the dict approach makes sense imo especially because you can get rid of the # noqa PLR0911 part as a result.

[powertools-for-aws-oss-automation]

Warning

This issue is now closed. Please be mindful that future comments are hard for our team to see.
If you need more assistance, please either reopen the issue, or open a new issue referencing this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.