Skip to content

Exclude dropped students from watchlist during refresh and updates#1630

Merged
victorhuangwq merged 6 commits intomasterfrom
exclude-dropped-students
Oct 30, 2022
Merged

Exclude dropped students from watchlist during refresh and updates#1630
victorhuangwq merged 6 commits intomasterfrom
exclude-dropped-students

Conversation

@victorhuangwq
Copy link
Copy Markdown
Contributor

Description

  • Removing dropped students when refreshing the watchlist
  • Exclude dropped students from being considered when conditions are updated

Motivation and Context

Addresses the open issue here: #1611

How Has This Been Tested?

Testing dropping pending student

Initial State:
Screen Shot 2022-10-27 at 2 18 43 PM

I proceeded then to:

  • Drop User0 from the course
  • Click the Refresh button on the watchlist

Screen Shot 2022-10-27 at 2 23 23 PM

I then updated the conditions (change of metric conditions in the student metrics tab):
Screen Shot 2022-10-27 at 2 24 03 PM

I proceeded then to:

  • Undrop User0
  • Click the Refresh button on the watchlist

Screen Shot 2022-10-27 at 2 24 55 PM

Testing dropping contacted / resolved student

I resolved User0 (using the resolve button):
image

I then proceeded then to:

  • Drop User0
  • Click the Refresh button on the watchlist

image

I then updated the conditions (change of metric conditions in the student metrics tab):
image

I then proceeded then to:

  • Undrop User0
  • Click the Refresh button on the watchlist

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

Copy link
Copy Markdown
Contributor

@20wildmanj 20wildmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed testing strategy, functionality works as specified. LGTM

@victorhuangwq victorhuangwq merged commit 5327388 into master Oct 30, 2022
@victorhuangwq victorhuangwq deleted the exclude-dropped-students branch October 30, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Student watchlist screen should not include students marked as dropped

2 participants