Exclude dropped students from watchlist during refresh and updates#1630
Merged
victorhuangwq merged 6 commits intomasterfrom Oct 30, 2022
Merged
Exclude dropped students from watchlist during refresh and updates#1630victorhuangwq merged 6 commits intomasterfrom
victorhuangwq merged 6 commits intomasterfrom
Conversation
20wildmanj
reviewed
Oct 28, 2022
20wildmanj
reviewed
Oct 28, 2022
20wildmanj
approved these changes
Oct 28, 2022
Contributor
20wildmanj
left a comment
There was a problem hiding this comment.
Followed testing strategy, functionality works as specified. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Addresses the open issue here: #1611
How Has This Been Tested?
Testing dropping pending student
Initial State:

I proceeded then to:
I then updated the conditions (change of metric conditions in the student metrics tab):

I proceeded then to:
Testing dropping contacted / resolved student
I resolved User0 (using the resolve button):

I then proceeded then to:
I then updated the conditions (change of metric conditions in the student metrics tab):

I then proceeded then to:
Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for lintingOther issues / help required
If unsure, feel free to submit first and we'll help you along.