Fix roster format

[damianhxy]

Description

• When exporting roster, use @course.name for the missing courseNumber column
• Make ROSTER_COLUMNS_F16 and ROSTER_COLUMNS_F20 use Lecture (rather than Course) for courseLecture field.
• Added entire ROSTER_COLUMNS_F16 and ROSTER_COLUMNS_F20 formats in comments
• Map map[0] (Semester) to -1 since it is not used
• Fix mapping for grading_policy in ROSTER_COLUMNS_F16 format

Motivation and Context

The "General Autolab Format" is described by Semester,email,last_name,first_name,school,major,year,grading_policy,courseNumber,courseLecture,section.

Inside parse_roster_csv, the corresponding fields are extracted (except for Semester and courseNumber, since the data is stored in @course). However, when exporting a roster, the courseNumber column is not outputted, which causes the columns to shift if we reimport the data (courseLecture will now take on the value of section, and section will be blank). This PR fixes this by using @course.name for the courseNumber column.

Furthermore, when processing Roster formats ROSTER_COLUMNS_F16 and ROSTER_COLUMNS_F20, the Course field, instead of the Lecture field, is mapped to courseLecture, meaning that we are recording the Course name (e.g. 15122) as the Lecture number (which should be 1, 2, etc.). In older format ROSTER_COLUMNS_S15, the courseLecture was correctly mapped to the Lecture field.

Fixes #997.

How Has This Been Tested?

Test 1: Ensure General Autolab Format still works correctly

Roster

M22,xho@foo.bar,Ho,Damian,SCS,CS,2025,L,15122,1,A

Test 2: Check that Export + Import works correctly

Roster (Note the 4 undropped students)

Before PR: Export + Import

Observe that the section letter shifted into the lecture column.

After PR: Export + Import

Test 3: Check that CMU Roster Format works correctly

Roster

Semester,Course,Section,Lecture,Mini,Last Name,Preferred/First Name,MI,Andrew ID,Email,College,Department,Major,Class,Graduation Semester,Units,Grade Option,QPA Scale,Mid-Semester Grade,Primary Advisor,Final Grade,Default Grade,Time Zone Code,Time Zone Description,Added By,Added On,Confirmed,Waitlist Position,Units Carried/Max Units,Waitlisted By,Waitlisted On,Dropped By,Dropped On,Roster As Of Date
M22,15122,A,1,N,Ho,Damian,,xho,xho@andrew.cmu.edu,SCS,CS,CS,3,F25,0,L,4+,,Test Advisor,,,EST,Eastern Standard Time (GMT-5:00),fake_andrewid,11 Jul 2022,Y,,,,,,,11 Jul 2022 12:00 AM

Before PR

Observe that Course number appears in the lecture field.

After PR

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
• My change requires a change to the documentation, which is located at Autolab Docs
• I have updated the documentation accordingly, included in this PR

[fanpu]

Great work catching this and the changes looks good! Could you also update the comments to include the subsequent columns that were elided so people will be able to know the entire roster format in the future?

[damianhxy]

To be fully consistent with what we're doing with SIO rosters (i.e. dropping the Semester and Course columns here, even though they will be ignored later on anyway), we should technically use a "map" here [-1, 1, 2, 3, 4, 5, 6, 7, -1, 9, 10]. However, this doesn't make a difference unless for some reason we make use of those columns in the future.

[fanpu]

Updated changes looks good, don't worry about the stuff from S15 too, no one should be using those now