Skip to content
This repository was archived by the owner on Jul 27, 2023. It is now read-only.

Fix ArgWithDefault TextRange - #13

Merged
MichaReiser merged 1 commit into
mainfrom
fix-arg-with-default-range
Jun 20, 2023
Merged

MichaReiser merged 1 commit into
mainfrom
fix-arg-with-default-range

Conversation

@MichaReiser

Copy link
Copy Markdown
Member

This PR fixes the range of ArgWithDefault to include the argument and the default value.

@MichaReiser

Copy link
Copy Markdown
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@konstin konstin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a partial review

image

@MichaReiser
MichaReiser force-pushed the fix-arg-with-default-range branch from db0735c to 9534abc Compare June 20, 2023 16:09
@MichaReiser

MichaReiser commented Jun 20, 2023 •

Copy link
Copy Markdown
Member Author

I've done a partial review

image

Haha yeah. This file is auto generated. I've no idea why adding a single block triggers 17k changed lines

@MichaReiser
MichaReiser merged commit 08ebbe4 into main Jun 20, 2023
@MichaReiser
MichaReiser deleted the fix-arg-with-default-range branch June 20, 2023 16:21
zanieb added a commit that referenced this pull request Jul 10, 2023
zanieb added a commit that referenced this pull request Jul 17, 2023
zanieb pushed a commit that referenced this pull request Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants