Measure column widths after character escaping (fixes #244) - #445
Open
IMGillusion wants to merge 1 commit into
Open
Measure column widths after character escaping (fixes #244)#445IMGillusion wants to merge 1 commit into
IMGillusion wants to merge 1 commit into
Conversation
Formats with per-character escape rules (latex, github) escaped special characters at render time, i.e. after padding, so escaped cells were wider than the measured column widths and rows misaligned. Apply the escaping before widths are measured, then drop the escape rules from the row formatters to avoid escaping twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #244.
tabulate(..., tablefmt="latex")escaped special characters (e.g._->\_)only at render time, after padding. Column widths were measured on the
unescaped text, so any escaped cell rendered wider than its measured
width and the
&separators (and|ingithubtables) stopped liningup across rows:
This applies the same per-character escaping before widths are measured
(after cell formatting, before alignment), then replaces the affected
row formatters with copies that carry no escape map so nothing is
escaped twice. The format objects are copied per call, so shared
module-level
TableFormats are never mutated.latex_raw(no escaperules) and all formats without an escape map are untouched.
test_latex_escaped_cell_width(issue example +asserts every
&sits in the same column)misaligned rendering (
test_latex,test_latex_escape_special_chars,test_github_escape_pipe_character)Full suite: 383 passed, 1 skipped (pytest with --doctest-modules,
including README.md doctests).